Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi field terms #116928

Merged
merged 18 commits into from
Nov 23, 2021
Merged

Multi field terms #116928

merged 18 commits into from
Nov 23, 2021

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Nov 1, 2021

Implements multi field terms agg config. Other bucket is supported, missing bucket is not.
Refactors common parts between terms and multi_terms into a common place.

To test the expression level:
Start node scripts/functional_tests_server.js --config test/interpreter_functional/config.ts
Go to the "Run pipeline app"
Do this in the console (check results and queries on the wire):

await window.runPipeline(`kibana_context timeRange={timerange from='2015-09-21T00:00:00Z' to='now+2y'}
          | esaggs index={indexPatternLoad id='90943e30-9a47-11e8-b64d-95841ca0b247'}
          aggs={aggMultiTerms id="0" enabled=true schema="bucket" fields="extension.keyword" fields="geo.dest" size=20 orderAgg={aggCount id="order" enabled=true schema="metric"}}
          aggs={aggCount id="1" enabled=true schema="metric"}`, null, {})

See test cases in https://github.com/elastic/kibana/pull/116928/files#diff-3113b5ed44b84abf6e4829a3bac5cd7982220cab058ff938defa26bef0ccb03b

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:feature Makes this part of the condensed release notes v8.1.0 release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesSv and removed release_note:feature Makes this part of the condensed release notes labels Nov 1, 2021
@elastic elastic deleted a comment from kibanamachine Nov 15, 2021
@flash1293 flash1293 marked this pull request as ready for review November 15, 2021 13:21
@flash1293 flash1293 requested review from a team as code owners November 15, 2021 13:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review for the @elastic/kibana-vis-editors files only 👍

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 500 505 +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2853 2866 +13

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 431.9KB 438.0KB +6.1KB
visTypeMetric 8.7KB 8.7KB +15.0B
visTypePie 13.7KB 13.7KB +30.0B
visTypeVislib 19.7KB 19.7KB +75.0B
visTypeXy 39.7KB 39.9KB +180.0B
total +6.4KB
Unknown metric groups

API count

id before after diff
data 3245 3258 +13

References to deprecated APIs

id before after diff
data 463 475 +12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app services code LGTM

@flash1293 flash1293 added the backport:skip This commit does not require backporting label Nov 23, 2021
@flash1293 flash1293 merged commit 079db96 into elastic:main Nov 23, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants