-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi field terms #116928
Multi field terms #116928
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review for the @elastic/kibana-vis-editors files only 👍
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
@elasticmachine merge upstream |
merge conflict between base and head |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app services code LGTM
Implements multi field terms agg config. Other bucket is supported, missing bucket is not.
Refactors common parts between terms and multi_terms into a common place.
To test the expression level:
Start
node scripts/functional_tests_server.js --config test/interpreter_functional/config.ts
Go to the "Run pipeline app"
Do this in the console (check results and queries on the wire):
See test cases in https://github.com/elastic/kibana/pull/116928/files#diff-3113b5ed44b84abf6e4829a3bac5cd7982220cab058ff938defa26bef0ccb03b