Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Log TM health and drift stats prior to reporting tests #117013

Merged

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Nov 1, 2021

Closes #114946
Partially addresses #93354

Looking at the test failures for "Reporting APIs BWC report generation urls Pre 6_2 job posted successfully" showed logs where the task for the report was never claimed, due to health problems with Task Manager.

This PR addresses the problem by adding TM health stats to the logs prior to running the reporting tests. If the test continues to be flaky, we should look at the TM logs and see if the there was a problem with Task Manager at the time.

@tsullivan tsullivan requested review from a team as code owners November 1, 2021 18:29
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx v7.16.1 v8.0.0 v8.1.0 labels Nov 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan added the SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week label Nov 1, 2021
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the context, I think the reasoning behind this change makes sense. It's not clear what reporting should do differently if TM is unhealthy/unable to claim jobs.

@tsullivan
Copy link
Member Author

Updated the description to say this PR "Partially addresses #93354" rather than closes it.

@tsullivan tsullivan enabled auto-merge (squash) November 2, 2021 18:58
@tsullivan tsullivan merged commit 2f8dfba into elastic:main Nov 2, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan added a commit to tsullivan/kibana that referenced this pull request Nov 2, 2021
…lastic#117013)

* [Reporting] Log TM health and drift stats prior to reporting tests

Closes elastic#114946

* re-skip flaky test

* rename method
tsullivan added a commit to tsullivan/kibana that referenced this pull request Nov 2, 2021
…lastic#117013)

* [Reporting] Log TM health and drift stats prior to reporting tests

Closes elastic#114946

* re-skip flaky test

* rename method
@tsullivan tsullivan deleted the reporting/tests-log-tm-health-stats branch November 2, 2021 23:32
tsullivan added a commit to tsullivan/kibana that referenced this pull request Nov 2, 2021
…lastic#117013)

* [Reporting] Log TM health and drift stats prior to reporting tests

Closes elastic#114946

* re-skip flaky test

* rename method
tsullivan added a commit that referenced this pull request Nov 3, 2021
…117013) (#117249)

* [Reporting] Log TM health and drift stats prior to reporting tests

Closes #114946

* re-skip flaky test

* rename method
tsullivan added a commit that referenced this pull request Nov 3, 2021
…117013) (#117247)

* [Reporting] Log TM health and drift stats prior to reporting tests

Closes #114946

* re-skip flaky test

* rename method
tsullivan added a commit that referenced this pull request Nov 3, 2021
…117013) (#117248)

* [Reporting] Log TM health and drift stats prior to reporting tests

Closes #114946

* re-skip flaky test

* rename method
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week v7.15.2 v7.16.1 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting] Resolve failures in legacy PDF API integration tests
5 participants