-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Fleet setup call from Integrations app #117383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.16.0
v8.1.0
Feature:Unified Integrations
Unified Integrations view feature
labels
Nov 3, 2021
Pinging @elastic/fleet (Team:Fleet) |
joshdover
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Nov 3, 2021
kpollich
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
💛 Build succeeded, but was flaky
Test FailuresMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @joshdover |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 3, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Unified Integrations
Unified Integrations view feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.16.0
v8.0.0
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improves the experience when Fleet setup fails for some reason by still allowing the user to view the other integrations. Instead, setup is called when the user starts adding their first Fleet integration and are redirected to the Fleet app.
It also greatly improves the load time for the Integrations app for on-prem users who have not yet run the Fleet setup process.