Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fleet setup call from Integrations app #117383

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Nov 3, 2021

Summary

This improves the experience when Fleet setup fails for some reason by still allowing the user to view the other integrations. Instead, setup is called when the user starts adding their first Fleet integration and are redirected to the Fleet app.

It also greatly improves the load time for the Integrations app for on-prem users who have not yet run the Fleet setup process.

@joshdover joshdover added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.1.0 Feature:Unified Integrations Unified Integrations view feature labels Nov 3, 2021
@joshdover joshdover requested a review from a team as a code owner November 3, 2021 17:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover joshdover added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 3, 2021
@joshdover joshdover enabled auto-merge (squash) November 3, 2021 17:07
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshdover joshdover enabled auto-merge (squash) November 3, 2021 17:27
@joshdover joshdover merged commit b609b1e into elastic:main Nov 3, 2021
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] OSS CI Group #2 / bfetch explorer batchedFunction streams results back

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 615.7KB 614.9KB -828.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @joshdover

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 3, 2021
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Nov 3, 2021
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Unified Integrations Unified Integrations view feature release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants