[Discover] Fix reselecting another surrounding document #117567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
kertal
added
v7.16.0
v8.0.0
v8.1.0
release_note:skip
kertal
commented
Nov 5, 2021
| */ | ||
| useEffect(() => { | ||
| if (prevAppState.current) { | ||
| prevAppState.current = undefined; |
There was a problem hiding this comment.
if the anchor changes in the url, resetting the prevAppState automatically triggers a reload of all documents
kertal
added
the
auto-backport
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
majagrubic
approved these changes
Nov 9, 2021
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 9, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 9, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 9, 2021
…) (#117996) Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Nov 9, 2021
…) (#117997) Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When clicking on
View surrounding documentsfrom a context view, the link didn't behave like it should. New documents were loaded, but the anchor was is no longer highlighted.This PR fixes this, so you should be able to
Fixes #116644
Checklist