Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Renames index pattern in management and monitoring #117939

Merged
merged 7 commits into from
Nov 10, 2021

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Nov 8, 2021

Summary

Renames index patterns to data views in the following sections of the docs:

  • Stack Management
  • Monitoring
  • Graph
  • Landing page

@gchaps gchaps added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 8, 2021
@lcawl
Copy link
Contributor

lcawl commented Nov 9, 2021

@elasticmachine run elasticsearch-ci/docs

@lcawl
Copy link
Contributor

lcawl commented Nov 9, 2021

@elasticmachine update branch

@gchaps gchaps marked this pull request as ready for review November 9, 2021 22:27
@gchaps gchaps requested a review from a team as a code owner November 9, 2021 22:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps gchaps requested a review from lcawl November 9, 2021 22:32
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise LGTM

docs/user/monitoring/kibana-alerts.asciidoc Outdated Show resolved Hide resolved
gchaps and others added 2 commits November 9, 2021 15:11
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@gchaps
Copy link
Contributor Author

gchaps commented Nov 10, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #2 / Saved objects management feature controls saved objects management global saved object management read privileges listing shows all saved objects

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 268.1KB 268.1KB -4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gchaps gchaps merged commit 4216895 into elastic:main Nov 10, 2021
@gchaps gchaps deleted the docs/rename-index-pattern-in-management branch November 10, 2021 18:20
gchaps added a commit to gchaps/kibana that referenced this pull request Nov 10, 2021
…7939)

* [DOCS] Renames index pattern in management, monitoring, and graph

* [DOCS] Renames index pattern on landing page

* Updates URL in doc link service

* Update docs/management/advanced-options.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/user/monitoring/kibana-alerts.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

Co-authored-by: lcawl <lcawley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Nov 10, 2021
…118225)

* [DOCS] Renames index pattern in management, monitoring, and graph

* [DOCS] Renames index pattern on landing page

* Updates URL in doc link service

* Update docs/management/advanced-options.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/user/monitoring/kibana-alerts.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

Co-authored-by: lcawl <lcawley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: lcawl <lcawley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants