Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index pattern creation] Move the error message to below the input field #11801

Merged
merged 2 commits into from
May 16, 2017
Merged

[Index pattern creation] Move the error message to below the input field #11801

merged 2 commits into from
May 16, 2017

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented May 15, 2017 •
edited
Loading

Closes #11410

Summary

This PR makes a small change to the index pattern creation page by surfacing index-related errors directly underneath the input field, rather than on the Create button. This helps visually connect the error with the state causing the error. It's important to note that the Create button will continue to be disabled in this error state, just as before.

If it's not obvious, the new UI is based off the StatusText UI component

Screenshots

New Error Surfacing

screen shot 2017-05-15 at 3 09 22 pm

Old Error Surfacing

screen shot 2017-05-15 at 3 08 50 pm

@chrisronline chrisronline self-assigned this May 15, 2017
ycombinator
ycombinator requested changes May 16, 2017
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality LGTM. Left a minor comment on the code.

...ins/kibana/public/management/sections/indices/create_index_pattern/create_index_pattern.html Outdated
@@ -44,6 +44,16 @@
>
</div>

<!-- Input error text -->
<div class="kuiVerticalRhythm" ng-if="controller.fetchFieldsError">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our HTML styleguide we break up tags with multiple attributes onto multiple lines, so its more readable + easy to see attribute adds/removes later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np, good to know. I'll fix it up

ycombinator
ycombinator approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BigFunger
BigFunger approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@BigFunger BigFunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisronline chrisronline merged commit c2319d5 into elastic:master May 16, 2017
chrisronline added a commit that referenced this pull request May 16, 2017
@chrisronline
[Index pattern creation] Move the error message to below the input fi…
09d97ba 
…eld (#11801)

* Move the error message to below the input field, resolves #11410

* Update to match HTML styleguide
@chrisronline
Copy link
Contributor Author

Backport

5.x: 09d97ba

@chrisronline chrisronline deleted the enhancement/index-pattern-error-surfacing branch May 16, 2017 16:27
@spalger
Copy link
Contributor

spalger commented May 16, 2017

@chrisronline the 5.x branch is for the upcomming 5.5 release, if you really want this to go out with 5.4.1 (should we ship it) it would need to be backported to the 5.4 branch as well.

@chrisronline
Copy link
Contributor Author

chrisronline commented May 17, 2017 •
edited
Loading

@spalger Yup! It's an enhancement so I don't think we need it in 5.4.x, plus the directory structure changed quite a bit from 5.4 -> 5.5 so a potentially painful backport combined with not really needing to backport enhancements resulted in me just putting in 5.x for the next minor bump off 5.

EDIT: and I see the confusion. I should have removed the 5.4.0 label once I realized it wasn't going in. My bad and thanks for double checking this

snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
@chrisronline @snide
[Index pattern creation] Move the error message to below the input fi…
3e046a3 
…eld (elastic#11801)

* Move the error message to below the input field, resolves elastic#11410

* Update to match HTML styleguide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigFunger BigFunger BigFunger approved these changes

@ycombinator ycombinator ycombinator approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:enhancement v5.5.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisronline @spalger @ycombinator @BigFunger