Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bluebird dependency #118097

Merged
merged 11 commits into from
Nov 11, 2021
Merged

Remove bluebird dependency #118097

merged 11 commits into from
Nov 11, 2021

Conversation

watson
Copy link
Contributor

@watson watson commented Nov 9, 2021

Good native promises have been a thing for a while, so there's really no reason to keep Bluebird around. This also gets us one step closer to getting rid of eval usage server-side (an unfortunate internal side-effect of Bluebird).

Closes #49602

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 labels Nov 9, 2021
@watson watson self-assigned this Nov 9, 2021
This was referenced Nov 9, 2021
Open
Closed
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #6 / apis Machine Learning modules "after all" hook in "modules"
  • [job] [logs] Default CI Group #6 / apis Machine Learning modules "before all" hook in "modules"

Metrics [docs]

✅ unchanged

History

  • 💔 Build #5556 failed 6055feeb434e8b8a5f71623f755820555738fb22

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson marked this pull request as ready for review November 10, 2021 17:05
@watson watson requested review from a team as code owners November 10, 2021 17:05
paul-tavares
paul-tavares approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks for the updates in security solution.

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

dej611
dej611 approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left only a comment.
Reviewed for @kibana_vis_editors

src/plugins/vis_types/timelion/server/routes/run.ts Show resolved Hide resolved
@weltenwort weltenwort self-requested a review November 10, 2021 18:06
weltenwort
weltenwort approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monitoring plugin changes LGTM

kpollich
kpollich approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM

LeeDr
LeeDr approved these changes Nov 10, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-qa changes lgtm

patrykkopycinski
patrykkopycinski approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asset management LGTM

shahzad31
shahzad31 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

@watson watson merged commit 788db0d into elastic:main Nov 11, 2021
@watson watson deleted the remove-bluebird branch November 11, 2021 14:17
@legrego legrego mentioned this pull request Nov 15, 2021
Closed
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@watson @dmlemeshko
Remove bluebird dependency (#118097)
62afb07
This was referenced Jul 31, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

@LeeDr LeeDr LeeDr approved these changes

@kpollich kpollich kpollich approved these changes

@jportner jportner jportner approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@jbudz jbudz jbudz approved these changes

@weltenwort weltenwort weltenwort approved these changes

@academo academo academo approved these changes

Assignees

@watson watson

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove bluebird dependency