Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Framework] Fix React Warning in Demo Site #11822

Merged
merged 1 commit into from
May 16, 2017
Merged

[UI Framework] Fix React Warning in Demo Site #11822

merged 1 commit into from
May 16, 2017

Conversation

tsullivan
Copy link
Member

This fixes the React warning I discovered in #11811 and described in the description of that PR.

NOTE: when running the test site, I noticed there are some React warnings printed out in the JS console. This seems to happen in the master branch as well:

image

@tsullivan tsullivan added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. bug Fixes for quality problems that affect the customer experience v5.5.0 v6.0.0 labels May 16, 2017
@tsullivan tsullivan requested a review from cjcenizal May 16, 2017 17:27
cjcenizal
cjcenizal approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!! LGTM.

@tsullivan tsullivan merged commit f6683cb into elastic:master May 16, 2017
@tsullivan tsullivan deleted the fix/ui-fmwk-guidenav-11811 branch May 16, 2017 18:38
tsullivan added a commit to tsullivan/kibana that referenced this pull request May 16, 2017
@tsullivan
Fix React Warning in Demo Site (elastic#11822)
4db5997
@tsullivan
Copy link
Member Author

5.x/5.5.0: 4db5997

snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
@tsullivan @snide
Fix React Warning in Demo Site (elastic#11822)
5a894ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.5.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsullivan @cjcenizal @jimgoodwin