Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Generate stack monitoring data #118302

Merged
merged 15 commits into from
Nov 29, 2021
Merged

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Nov 11, 2021

Fixes #117615

@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 11, 2021
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into a bunch of bootstrap reference errors here (looks like the apm integration and e2e tests rely on this code).

Can I just ignore these and use the code you have here to produce some documents?

@@ -1,67 +0,0 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this supposed to be deleted? Looks like clean_write_targets.ts still imports it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had duplicated files, renaming that import to create_logger.ts should work. And yeah you can safely ignore the bootstrap reference errors (I've disabled those in my local setup).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. How do you disable those? For now I've just ignored them.

@matschaffer
Copy link
Contributor

I tried running this with

node packages/elastic-apm-synthtrace/src/scripts/run packages/elastic-apm-synthtrace/src/scripts/examples/01_simple_trace.ts --target=http://elastic:changeme@localhost:9200 --writeTarget=.monitoring-es

But I just get the same Write targets could not be determined as before.

Do you have an example on how to run this with a monitoring write target?

@miltonhultgren
Copy link
Contributor

miltonhultgren commented Nov 24, 2021

The command I'm running is node ./src/scripts/run ./src/scripts/examples/02_kibana_stats.ts --target=http://elastic:changeme@localhost:9200 --writeTarget=.monitoring-kibana-7-2021.11.24 (inside of the synthtrace package folder)

(The 01_simple_trace.ts scenario seems wired for APM data which expects the indices to be pre-setup)

@elastic elastic deleted a comment from kibanamachine Nov 24, 2021
@matschaffer
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@matschaffer
Copy link
Contributor

Marking as "fixes" for SM generation - what we have isn't complete but it does work. So we can probably call the issue done once this is merged.

@dgieselaar
Copy link
Member Author

@matschaffer @miltonhultgren cool, I'll clean up and pull this out of draft.

@miltonhultgren miltonhultgren marked this pull request as ready for review November 25, 2021 14:30
@miltonhultgren miltonhultgren requested a review from a team as a code owner November 25, 2021 14:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@matschaffer
Copy link
Contributor

@elasticmachine merge upstream

@matschaffer matschaffer enabled auto-merge (squash) November 29, 2021 04:49
@miltonhultgren
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Member Author

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! (can't approve, as it's my own PR)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@elastic/apm-synthtrace 43 47 +4

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@elastic/apm-synthtrace 6 7 +1
Unknown metric groups

API count

id before after diff
@elastic/apm-synthtrace 43 47 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@matschaffer matschaffer merged commit 39a29cc into elastic:main Nov 29, 2021
@dgieselaar dgieselaar added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 30, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2021
* Generate stack monitoring data

* Update file import

* Fix imports after bad merge from upstream

* A cluster stats generator

* Wiring kibana docs to ES docs

* Adding fields to get kibana cards rendering

* [apm-synthtrace] Export types Fields, ApmException, ApmSynthtraceEsClient

* [APM] Update integration tests with synthtrace changes

* [APM] Update Cypress E2E tests with synthtrace changes

* Fix lint errors

Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
Co-authored-by: Mat Schaffer <mat@elastic.co>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 30, 2021
* Generate stack monitoring data

* Update file import

* Fix imports after bad merge from upstream

* A cluster stats generator

* Wiring kibana docs to ES docs

* Adding fields to get kibana cards rendering

* [apm-synthtrace] Export types Fields, ApmException, ApmSynthtraceEsClient

* [APM] Update integration tests with synthtrace changes

* [APM] Update Cypress E2E tests with synthtrace changes

* Fix lint errors

Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
Co-authored-by: Mat Schaffer <mat@elastic.co>

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
Co-authored-by: Mat Schaffer <mat@elastic.co>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
* Generate stack monitoring data

* Update file import

* Fix imports after bad merge from upstream

* A cluster stats generator

* Wiring kibana docs to ES docs

* Adding fields to get kibana cards rendering

* [apm-synthtrace] Export types Fields, ApmException, ApmSynthtraceEsClient

* [APM] Update integration tests with synthtrace changes

* [APM] Update Cypress E2E tests with synthtrace changes

* Fix lint errors

Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
Co-authored-by: Mat Schaffer <mat@elastic.co>
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
* Generate stack monitoring data

* Update file import

* Fix imports after bad merge from upstream

* A cluster stats generator

* Wiring kibana docs to ES docs

* Adding fields to get kibana cards rendering

* [apm-synthtrace] Export types Fields, ApmException, ApmSynthtraceEsClient

* [APM] Update integration tests with synthtrace changes

* [APM] Update Cypress E2E tests with synthtrace changes

* Fix lint errors

Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
Co-authored-by: Mat Schaffer <mat@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Create simulator for stack monitoring data
7 participants