Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Fixes configuration page flaky tests #118521

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

cnasikas
Copy link
Member

Summary

Fixes: #116825, #115366

Checklist

For maintainers

@cnasikas cnasikas self-assigned this Nov 15, 2021
@cnasikas cnasikas requested a review from a team as a code owner November 15, 2021 12:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 15, 2021
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cnasikas cnasikas merged commit a247508 into elastic:main Nov 16, 2021
@cnasikas cnasikas deleted the fix_conf_flacky_tests branch November 16, 2021 11:46
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 16, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
8.0
7.16 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 118521

kibanamachine added a commit that referenced this pull request Nov 16, 2021
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
cnasikas added a commit that referenced this pull request Nov 16, 2021
# Conflicts:
#	x-pack/plugins/cases/public/components/configure_cases/index.test.tsx
cnasikas added a commit that referenced this pull request Nov 16, 2021
* [Cases] Fixes configuration page flaky tests (#118521)

# Conflicts:
#	x-pack/plugins/cases/public/components/configure_cases/index.test.tsx

* Fix lint errors

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment