Use documentation link service in index lifecycle management #118623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
lcawl
added
Feature:ILM
v8.0.0
v8.1.0
enhancement
sabarasaba
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Thanks for patching this up @lcawl! changes lgtm, didn't test locally
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Nov 17, 2021
lcawl
added a commit
that referenced
this pull request
Nov 17, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #88107
This PR uses the documentation link service in https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_lifecycle_management/public/application/services/documentation.ts and https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/no_custom_attributes_messages.tsx instead of hard-coded links that are not tested or maintained.