Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] API integration tests for ML Anomaly detection alerting rule #118726

Merged
merged 10 commits into from
Dec 7, 2021
Merged

[ML] API integration tests for ML Anomaly detection alerting rule #118726

merged 10 commits into from
Dec 7, 2021

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Nov 16, 2021 •
edited
Loading

Summary

Adds API integration tests for the ML alerting rules

Checklist

@darnautov darnautov self-assigned this Nov 25, 2021
@darnautov darnautov added Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types release_note:skip Skip the PR/issue when compiling release notes test_api v8.1.0 :ml labels Nov 25, 2021
@darnautov darnautov marked this pull request as ready for review November 25, 2021 16:35
@darnautov darnautov requested a review from a team as a code owner November 25, 2021 16:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

YulNaumenko
YulNaumenko approved these changes Nov 28, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the green CI

@peteharverson peteharverson mentioned this pull request Nov 30, 2021
Closed
13 tasks
@darnautov
Copy link
Contributor Author

darnautov commented Dec 6, 2021 •
edited
Loading

Checking with flaky test runner...
50/50 🟢

@darnautov darnautov changed the title [ML] API integration tests for ML alerting rules [ML] API integration tests for ML Anomaly detection alerting rule Dec 6, 2021
pheyos
pheyos approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one minor comment.

...alerting_api_integration/spaces_only/tests/alerting/ml_rule_types/anomaly_detection/alert.ts Outdated Show resolved Hide resolved
peteharverson
peteharverson approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is it worth ml-ui as codeowners for x-pack/test/alerting_api_integration/spaces_only/tests/alerting/ml_rule_types ?

@darnautov darnautov enabled auto-merge (squash) December 7, 2021 10:10
@darnautov darnautov added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 7, 2021
@peteharverson peteharverson mentioned this pull request Dec 7, 2021
Closed
3 tasks
@darnautov darnautov merged commit 8201bc0 into elastic:main Dec 7, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 8.0 Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 118726

@darnautov darnautov mentioned this pull request Dec 8, 2021
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 8, 2021
@darnautov
[ML] API integration tests for ML Anomaly detection alerting rule (el…
d3a1a59 
…astic#118726)

* WIP AD alerts tests

* update assertion

* delete jobs in afterEach

* add sleep and increase topN buckets

* remove console.log

* update CODEOWNERS
# Conflicts:
#	.github/CODEOWNERS
darnautov added a commit that referenced this pull request Dec 8, 2021
@darnautov
[ML] API integration tests for ML Anomaly detection alerting rule (#1…
6e7c791 
…18726) (#120728)

* WIP AD alerts tests

* update assertion

* delete jobs in afterEach

* add sleep and increase topN buckets

* remove console.log

* update CODEOWNERS
# Conflicts:
#	.github/CODEOWNERS
Heenawter pushed a commit to Heenawter/kibana that referenced this pull request Dec 8, 2021
@darnautov @Heenawter
[ML] API integration tests for ML Anomaly detection alerting rule (el…
9be54ab 
…astic#118726)

* WIP AD alerts tests

* update assertion

* delete jobs in afterEach

* add sleep and increase topN buckets

* remove console.log

* update CODEOWNERS
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@darnautov @TinLe
[ML] API integration tests for ML Anomaly detection alerting rule (el…
e97a91f 
…astic#118726)

* WIP AD alerts tests

* update assertion

* delete jobs in afterEach

* add sleep and increase topN buckets

* remove console.log

* update CODEOWNERS
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@darnautov @gbamparop
[ML] API integration tests for ML Anomaly detection alerting rule (el…
a5b4a7e 
…astic#118726)

* WIP AD alerts tests

* update assertion

* delete jobs in afterEach

* add sleep and increase topN buckets

* remove console.log

* update CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson peteharverson approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types :ml release_note:skip Skip the PR/issue when compiling release notes test_api v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson @YulNaumenko