[dev/server] ignore irrelevant changes in plugins #11884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
reviewed
May 18, 2017
src/cli/cluster/cluster_manager.js
Outdated
| ...settings.plugins.paths, | ||
| ...settings.plugins.scanDirs, | ||
| ], | ||
| [ |
There was a problem hiding this comment.
do we want to remove the outer array here? i don't think the ignore param expects a nested array
There was a problem hiding this comment.
is it worth ignoring __test__ too?
There was a problem hiding this comment.
@jbudz I think __tests__ is covered already in the regex below
There was a problem hiding this comment.
Whoops, it does, oddly enough, but that wasn't intended
There was a problem hiding this comment.
is it worth ignoring test too?
Yeah, __tests__ directories are ignored at any level
jbudz
approved these changes
May 18, 2017
kimjoar
approved these changes
May 18, 2017
spalger
added a commit
that referenced
this pull request
May 19, 2017
* [dev/server] ignore changes in test,build,scripts,docs dirs at root of plugins * [dev/clusterManager] unwrap extra ignore paths (cherry picked from commit c2ccab8)
|
5.x/5.5: 2d4e8fa |
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* [dev/server] ignore changes in test,build,scripts,docs dirs at root of plugins * [dev/clusterManager] unwrap extra ignore paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev server is currently watching all directories within plugins and scanDirs that don't match
/[\\\/](\..*|node_modules|bower_components|public|__tests__|coverage)[\\\/]/This pr adds to that list and excludes the
test,build,target,scriptsanddocsdirectories when they are at the root of a plugin.