[ftr] log async init errors right when they happen #11898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
ftr/log-async-init-errors
branch
from
f45a1f1 to
1fcf774
Compare
spalger
force-pushed
the
ftr/log-async-init-errors
branch
from
1fcf774 to
6f2f274
Compare
rhoboat
approved these changes
May 22, 2017
| @@ -35,16 +37,15 @@ export class ProviderCollection { | |||
| await instance.init(); | |||
| } | |||
| } catch (err) { | |||
| asyncInitErrors.push(err); | |||
| this._log.warning('Failure loading service %j', name); | |||
| this._log.error(err); | |||
| @@ -2,7 +2,8 @@ import { loadTracer } from '../load_tracer'; | |||
| import { createAsyncInstance, isAsyncInstance } from './async_instance'; | |||
|
|
|||
| export class ProviderCollection { | |||
| constructor(providers) { | |||
| constructor(log, providers) { | |||
| this._log = log; | |||
| this._instances = new Map(); | |||
| this._providers = providers; | |||
There was a problem hiding this comment.
the _private naming thing is a thing we do? is the point just to indicate to others that this is meant to be used in a private way?
spalger
added a commit
that referenced
this pull request
May 22, 2017
(cherry picked from commit 192b2ea)
|
5.5/5.x: 595294e |
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just throwing the first error that happens during async provider loading, log all errors as they occur and then throw an error at the end mentioning all of the services that failed, by name.