[tests/functional] catch and ignore errors during stabilization #11906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this |
rhoboat
reviewed
May 25, 2017
There was a problem hiding this comment.
This has been on my mind, so I'm glad we have this PR. Thanks, @spalger.
But, why do we have to wait for the config doc to be available in ES before it's considered stable, and therefore allowed to start? Is there a way to start up kibana without a .kibana? And just keep trying to create it in the background?
| @@ -32,29 +32,36 @@ export function KibanaServerProvider({ getService }) { | |||
| const startMs = Date.now(); | |||
| const timeout = config.get('timeouts.kibanaStabilize'); | |||
|
|
|||
| let exists; | |||
| let state; | |||
|
@archanid we don't have to, with enough retries things will eventually stabilize because the Kibana server is continuously checking for the config doc and creating it (or the whole .kibana index) when necessary. Adding enough retries in the right place is the tricky part though, this just tries to make the baseline for tests a bit more predictable. |
rhoboat
approved these changes
May 25, 2017
| return; | ||
| } | ||
| } catch (err) { | ||
| log.warning(`Failed to check for kibana stabilization: ${err.stack}`); |
spalger
added a commit
that referenced
this pull request
May 25, 2017
(cherry picked from commit eb31af6)
|
5.5/5.x: 0527267 |
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
spalger
deleted the
fix/test-functional-kibanaserver-errors-while-waiting-for-stablization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kibanaServerservice in the functional tests has awaitForStabilization()method that is called automatically before every test and tries to make sure that the kibana server isn't in a bad state before continuing. It does this by pinging the/api/statusroute and checking for the config document in elasticsearch.A recent failure in the tests shows that elasticsearch responded with a 503 at this time, which is surprising but ultimately not something that should take down the
waitForStabilization()method, so these changes update the method to catch and log/ignore errorsthrown during the check procedure.