[Dashboard][Saved Object Tagging] Fix Duplicating Tags

[ThomThomson]

Summary

Fixes #118796

What is this bug?

References from by Value Visualizations should be extracted into the dashboard saved object in order for exporting to get the correct references. In 7.13.0 a system was added which prefixes each reference with the panel ID it came from, so that it can be matched up with the proper panel.

In the dashboard inject function, references are filtered for each panel by reading the panel id from the prefix. As a fallback, if no references are found matching that panel, all references from the dashboard are passed to the inject function for the associated embeddable type.

This fallback assumes that the inject function for the embeddable type is capable of determining which references are relevant to it, and only injecting those references. Unfortunately, the Lens inject function would copy over all references it was given.

Because by value Lens Panels existed in 7.12 without the prefixing system of subsequent versions, importing a dashboard with a by value Lens from 7.12.1 into a later version resulted in every reference from the dashboard existing in every lens panel. This included any tag references on the dashboard.

When extracting these references for saving, every lens panel would add its own version of the tag, prefixed with its embeddable id. Additionally, the tag extract system wasn't de-duping tags, because theoretically there should never be duplicates. This all resulted in an addition of a number of tags directly relating to the number of by value Lens Panels in the dashboard every time the dashboard was saved.

What is the fix?

Firstly, the Lens inject function now uses its own internal references to match names on any references given to it during inject. This way, only relevant references are injected into the Lens panels. This stops the tags from duplicating, and stops the entire problem in its tracks when a dashboard is imported or migrated from 7.12.1.

Unfortunately, that fix cannot clean up any dashboards which have already suffered from the duplication problem, so a quick de-duping step was added to the tags extract function. Additionally, the dashboard extract function filters out any tags which mistakenly got added into the panel references.

[crob611]

Looks good. Nice job tracking that down.

[ThomThomson]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 57d4c77
• Storybooks Preview

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dashboard	64.5KB	64.6KB	+28.0B
lens	44.0KB	44.1KB	+147.0B
savedObjectsTaggingOss	2.4KB	2.4KB	+14.0B
total			+189.0B

History

• 💛 Build #7780 was flaky 0c3ae68

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[flash1293]

Tested and Lens references are filtered correctly, LGTM

[pgayvallet]

LGTM, thanks for tracking that on down.