Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating different index patterns with different time fields #11926

Merged
merged 2 commits into from
May 19, 2017

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented May 19, 2017

I need this change so that I can load other data sets for x-pack tests.

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test locally, but changes LGTM.

log.debug(`setIndexPatternField(${pattern})`);
return testSubjects.find('createIndexPatternNameInput')
.clearValue()
.type(pattern);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit - i think these two lines should be indented by two spaces.

@LeeDr LeeDr merged commit 1689fd8 into elastic:master May 19, 2017
@LeeDr LeeDr deleted the settingsPageForML branch May 23, 2017 13:53
snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
…lastic#11926)

* Allow creating different index patterns with different time fields

* Fix indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants