[Discover] Fix csv report for filtered discover result on dashboard #119583

dimaanj · 2021-11-24T10:34:10Z

Summary

Fixes #119452

This PR takes into consideration discover filters when generating csv report.

Test notes

Open discover
Create saved search with columns, apply filter
Create dashboard with saved search
Generate csv report via panel actions
Result should be filtered

dimaanj · 2021-11-24T16:02:05Z

@elasticmachine merge upstream

…oard

kertal

Code LGTM, will test it later on. Could you add a test for it? A functional for this one would be 🍰

kertal · 2021-11-29T07:16:19Z

@elasticmachine merge upstream

…oard

kertal

Code LGTM, tested a-la-carte using Chrome, created a saved search with filter, added to a dashboard, exported CSV. Result was as expected, filter added to saved search was considered in the CSV. Nice work! 👍

jloleysens

LGTM, did not test locally

jloleysens · 2021-11-29T13:07:26Z

src/plugins/discover/public/utils/get_sharing_data.ts

        ? data.query.timefilter.timefilter.createFilter(index)
        : data.query.timefilter.timefilter.createRelativeFilter(index);

-      searchSource.setField('filter', filter);
+      if (existingFilter && timeFilter) {
+        searchSource.setField(


I wonder how common this append to filter approach is. Perhaps it should be part of search source @elastic/kibana-app-services ?

cc @ppisljar

…ilters were applied for non time based data views

dimaanj · 2021-11-30T08:35:44Z

@elasticmachine merge upstream

…oard

elasticmachine · 2021-11-30T10:29:39Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal · 2021-12-01T09:59:54Z

@elasticmachine merge upstream

…oard

kibana-ci · 2021-12-01T11:17:47Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	312.2KB	312.4KB	+204.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`discover`	1824	1830	+6

History

💚 Build #9891 succeeded 8c7de03
💚 Build #9672 succeeded 013ae50
💚 Build #9492 succeeded 0a8c108
💛 Build #9278 was flaky 548011e
💚 Build #9064 succeeded 527bd79
💚 Build #9010 succeeded da3cf99

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

kibanamachine · 2021-12-01T11:32:19Z

💔 Backport failed

Status	Branch	Result
❌	7.16	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 119583

kibanamachine · 2021-12-03T11:35:00Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 119583 or prevent reminders by adding the backport:skip label.

…lastic#119583) * [Discover] fix csv report for filtered discover result on dashboard * [Discover] fix tests * [Discover] add functional test * [Discover] fix the case when timeFilter was not applied, but others filters were applied for non time based data views Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/discover/public/application/apps/main/utils/get_sharing_data.ts

…lastic#119583) * [Discover] fix csv report for filtered discover result on dashboard * [Discover] fix tests * [Discover] add functional test * [Discover] fix the case when timeFilter was not applied, but others filters were applied for non time based data views Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/discover/public/utils/get_sharing_data.ts

…119583) (#120418) * [Discover] fix csv report for filtered discover result on dashboard * [Discover] fix tests * [Discover] add functional test * [Discover] fix the case when timeFilter was not applied, but others filters were applied for non time based data views Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/discover/public/application/apps/main/utils/get_sharing_data.ts Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>

…119583) (#120419) * [Discover] fix csv report for filtered discover result on dashboard * [Discover] fix tests * [Discover] add functional test * [Discover] fix the case when timeFilter was not applied, but others filters were applied for non time based data views Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/discover/public/utils/get_sharing_data.ts Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>

…lastic#119583) * [Discover] fix csv report for filtered discover result on dashboard * [Discover] fix tests * [Discover] add functional test * [Discover] fix the case when timeFilter was not applied, but others filters were applied for non time based data views Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Discover] fix csv report for filtered discover result on dashboard

c9b3ca0

dimaanj added v8.1.0 v7.15.1 v7.16.1 labels Nov 24, 2021

dimaanj self-assigned this Nov 24, 2021

[Discover] fix tests

da3cf99

dimaanj marked this pull request as ready for review November 24, 2021 16:01

dimaanj requested a review from a team as a code owner November 24, 2021 16:01

dimaanj requested a review from tsullivan November 24, 2021 16:01

Merge branch 'main' into fix-csv-report-for-discover-filters-on-dashb…

527bd79

…oard

kertal reviewed Nov 25, 2021

View reviewed changes

[Discover] add functional test

548011e

dimaanj requested review from a team as code owners November 25, 2021 12:21

dimaanj requested a review from kertal November 25, 2021 14:29

Merge branch 'main' into fix-csv-report-for-discover-filters-on-dashb…

0a8c108

…oard

kertal approved these changes Nov 29, 2021

View reviewed changes

jloleysens approved these changes Nov 29, 2021

View reviewed changes

[Discover] fix the case when timeFilter was not applied, but others f…

013ae50

…ilters were applied for non time based data views

Merge branch 'main' into fix-csv-report-for-discover-filters-on-dashb…

8c7de03

…oard

dimaanj added auto-backport Deprecated - use backport:version if exact versions are needed and removed v7.15.1 labels Nov 30, 2021

dimaanj added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Nov 30, 2021

Merge branch 'main' into fix-csv-report-for-discover-filters-on-dashb…

3d9bf52

…oard

dimaanj merged commit 79079a7 into elastic:main Dec 1, 2021

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 3, 2021

tsullivan added v8.0.0 v7.17.0 labels Dec 3, 2021

tsullivan mentioned this pull request Dec 3, 2021

[8.0] [Discover] Fix csv report for filtered discover result on dashboard (#119583) #120418

Merged

tsullivan mentioned this pull request Dec 3, 2021

[7.16] [Discover] Fix csv report for filtered discover result on dashboard (#119583) #120419

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 3, 2021

This was referenced Jan 14, 2022

[Reporting] [Dashboard] [Maps] Failure when creating PNG report with map embeddable #122710

Closed

[Reporting] CSV Export URL generation adds an absolute time range filter #122575

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Fix csv report for filtered discover result on dashboard #119583

[Discover] Fix csv report for filtered discover result on dashboard #119583

dimaanj commented Nov 24, 2021 •

edited

Loading

dimaanj commented Nov 24, 2021

kertal left a comment •

edited

Loading

kertal commented Nov 29, 2021

kertal left a comment

jloleysens left a comment

jloleysens Nov 29, 2021

tsullivan Dec 3, 2021

dimaanj commented Nov 30, 2021

elasticmachine commented Nov 30, 2021

kertal commented Dec 1, 2021

kibana-ci commented Dec 1, 2021

References to deprecated APIs

kibanamachine commented Dec 1, 2021

kibanamachine commented Dec 3, 2021

[Discover] Fix csv report for filtered discover result on dashboard #119583

[Discover] Fix csv report for filtered discover result on dashboard #119583

Conversation

dimaanj commented Nov 24, 2021 • edited Loading

Summary

Test notes

dimaanj commented Nov 24, 2021

kertal left a comment • edited Loading

Choose a reason for hiding this comment

kertal commented Nov 29, 2021

kertal left a comment

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

jloleysens Nov 29, 2021

Choose a reason for hiding this comment

tsullivan Dec 3, 2021

Choose a reason for hiding this comment

dimaanj commented Nov 30, 2021

elasticmachine commented Nov 30, 2021

kertal commented Dec 1, 2021

kibana-ci commented Dec 1, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

References to deprecated APIs

History

kibanamachine commented Dec 1, 2021

💔 Backport failed

kibanamachine commented Dec 3, 2021

dimaanj commented Nov 24, 2021 •

edited

Loading

kertal left a comment •

edited

Loading