-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Update testing dev doc #119804
[APM] Update testing dev doc #119804
Conversation
Pinging @elastic/apm-ui (Team:apm) |
cbc8fd6
to
17d361c
Compare
@elasticmachine merge upstream |
The above command will initiate an Elasticsearch instance on http://localhost:9220 and a kibana instance on http://localhost:5620 and will run the api test against these environments. | ||
Once the tests finish, the instances will be terminated. | ||
|
||
### Start test server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Start test server" / "Run all tests" section could be moved under a debugging section or something similar so the difference to node scripts/test/api
is more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, the difference is that once the tests finish the instances(es & kibana) will be terminated in cases you run node scripts/test/api
script and I mention that on Run tests with [--trial] license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
💚 Build Succeeded
History
To update your PR or re-run it, just comment with: |
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
* [APM] Update testing dev doc * Update x-pack/plugins/apm/dev_docs/testing.md Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* [APM] Update testing dev doc * Update x-pack/plugins/apm/dev_docs/testing.md Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Kate Patticha <kate@kpatticha.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
* [APM] Update testing dev doc * Update x-pack/plugins/apm/dev_docs/testing.md Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Update testing.md readme