Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptimes] Push configs to service #120069

Merged
merged 10 commits into from
Dec 2, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 1, 2021

Closes elastic/uptime#422

Summary

Part of elastic/uptime#400

Push configs to service when monitor is added or when task manager is running.

Linked pushing configs to Add/Edit/Delete routes
Linked pushing configs to Task run

@elastic elastic deleted a comment from kibana-ci Dec 1, 2021
@shahzad31 shahzad31 marked this pull request as ready for review December 1, 2021 13:33
@shahzad31 shahzad31 requested a review from a team as a code owner December 1, 2021 13:33
@shahzad31 shahzad31 self-assigned this Dec 1, 2021
@shahzad31 shahzad31 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Dec 1, 2021
@@ -50,7 +50,7 @@ describe('getAPIKeyTest', function () {
cluster: ['monitor', 'read_ilm', 'read_pipeline'],
index: [
{
names: ['synthetics-*'],
names: ['synthetics-*', 'heartbeat-*'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this since we are not using data_stream format atm, so it's easier for testing, Will be removed afterwards

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Dec 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 2, 2021
@shahzad31 shahzad31 merged commit 3232689 into elastic:main Dec 2, 2021
@shahzad31 shahzad31 deleted the push_config_to_service branch December 2, 2021 09:47
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 6, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120069 or prevent reminders by adding the backport:skip label.

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Dec 6, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
shahzad31 added a commit that referenced this pull request Dec 6, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 6, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Push monitor configs to Synthetics Service
5 participants