Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy pre-4.2 configurations #12013

Merged
merged 1 commit into from
May 29, 2017

Conversation

epixa
Copy link
Contributor

@epixa epixa commented May 25, 2017

Prior to version 4.2.0, kibana.yml configurations used underscore as a
separator. In 4.2.0, this changed to dot instead, though the old
configuration names continued to work. In 5.0 we started logging
deprecation notices whenever the underscore-separated configurations
were encountered. Now we remove support for them entirely.

Closes #6743

@tylersmalley
Copy link
Contributor

tylersmalley commented May 25, 2017

Appears there is a test in src/server/config/__tests__/complete.js for the deprecated settings.

@epixa epixa force-pushed the 6743-removelegacyconfigs branch from 78fe1b5 to 8ed5bef Compare May 25, 2017 21:22
@epixa
Copy link
Contributor Author

epixa commented May 25, 2017

I updated that unit test to assert the server.ssl.cert rename specifically since it's clearly not a general purpose verification, and that happens to be the only rename configuration that still exists.

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Prior to version 4.2.0, kibana.yml configurations used underscore as a
separator. In 4.2.0, this changed to dot instead, though the old
configuration names continued to work. In 5.0 we started logging
deprecation notices whenever the underscore-separated configurations
were encountered. Now we remove support for them entirely.
@epixa epixa force-pushed the 6743-removelegacyconfigs branch from 8ed5bef to 290db86 Compare May 26, 2017 15:40
@epixa epixa merged commit 0384110 into elastic:master May 29, 2017
@epixa epixa deleted the 6743-removelegacyconfigs branch May 29, 2017 13:53
snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
Prior to version 4.2.0, kibana.yml configurations used underscore as a
separator. In 4.2.0, this changed to dot instead, though the old
configuration names continued to work. In 5.0 we started logging
deprecation notices whenever the underscore-separated configurations
were encountered. Now we remove support for them entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants