New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] Fixes terminology and splits tests to new case #120335

Merged

claudiopro merged 4 commits into elastic:main from claudiopro:issue_116476_fix

Dec 3, 2021

Contributor

claudiopro commented Dec 3, 2021

Summary

This PR is a follow up to #119750 to address additional feedback by @mgiota:

Splits rule stat tests to a new test case
Renames methods and vars that use the alerting service Alert semantics to Rule
Includes erroring rules in the total count

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

claudiopro added 2 commits

December 3, 2021 11:15


          Includes errors in the total number of rules

e84607b


          Fixes terminology and splits tests to new case

1bae172

claudiopro added auto-backport Team: Actionable Observability - DEPRECATED Theme: rac v8.0.0 v8.1.0 release_note:fix release_note:skip and removed release_note:fix labels

claudiopro requested review from mgiota and a team

December 3, 2021 10:35

claudiopro mentioned this pull request

[RAC] Adds stats about rules to Alerts page #119750

Merged

6 tasks


          Removes unused vars

e4f39fe

mgiota reviewed

View reviewed changes

x-pack/plugins/observability/public/pages/alerts/containers/alerts_page/alerts_page.tsx Outdated Show resolved Hide resolved


          Review feedback

0b6d992

mgiota approved these changes

View reviewed changes

Contributor

mgiota left a comment

@claudiopro LGTM! I made just a small comment

Contributor Author

claudiopro commented Dec 3, 2021

Thanks for the quick turnaround @mgiota !

claudiopro linked an issue

that may be closed by this pull request

[RAC] Add indicator about enabled / disabled rules on the alerts page #116476

Closed

Collaborator

kibana-ci commented Dec 3, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	362.2KB	362.2KB	-25.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

claudiopro merged commit 5bfaf51 into elastic:main

claudiopro deleted the issue_116476_fix branch

December 3, 2021 12:09

kibanamachine added the backport missing label

Contributor

kibanamachine commented Dec 7, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

4 similar comments

Contributor

kibanamachine commented Dec 8, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 9, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 10, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 13, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

fkanout mentioned this pull request

[RAC] [8.0.0] [META] Manually backport PRs to 8.0.0 #121165

Closed

3 tasks

Contributor

kibanamachine commented Dec 14, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Feb 25, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

24 similar comments

Contributor

kibanamachine commented Feb 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 2, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 3, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 4, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 7, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 8, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 9, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 10, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 11, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 14, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 15, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 16, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 17, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 18, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 21, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 23, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 24, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 25, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 29, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 30, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 31, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Apr 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120335 or prevent reminders by adding the backport:skip label.

spalger added v8.0.0 backport:skip and removed v8.0.0 labels

kibanamachine removed the backport missing label

spalger removed the v8.0.0 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport backport:skip release_note:skip Team: Actionable Observability - DEPRECATED Theme: rac v8.1.0