[ML] Add Maps ui action to Index data visualizer/Discover's Field statistics #120846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
release_note:enhancement
Feature:Discover
qn895
added
the
Team:DataDiscovery
|
Pinging @elastic/ml-ui (:ml) |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
...s/data_visualizer/public/application/common/components/field_data_row/action_menu/actions.ts
Outdated
Show resolved
Hide resolved
...n/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx
Outdated
Show resolved
Hide resolved
...s/data_visualizer/public/application/common/components/field_data_row/action_menu/actions.ts
Outdated
Show resolved
Hide resolved
nreese
approved these changes
Dec 13, 2021
peteharverson
approved these changes
Dec 14, 2021
|
@elasticmachine merge upstream |
kertal
approved these changes
Dec 14, 2021
Comment on lines
394
to
397
| JSON.stringify({ | ||
| searchQueryLanguage, | ||
| searchString, | ||
| }, | ||
| actionFlyoutRef | ||
| ); | ||
| if (!Array.isArray(actions) || actions.length < 1) return; | ||
|
|
||
| const actionColumn: EuiTableActionsColumnType<FieldVisConfig> = { | ||
| name: ( | ||
| <FormattedMessage | ||
| id="xpack.dataVisualizer.index.dataGrid.actionsColumnLabel" | ||
| defaultMessage="Actions" | ||
| /> | ||
| ), | ||
| actions, | ||
| width: '100px', | ||
| }; | ||
|
|
||
| return [actionColumn]; | ||
| }, [currentIndexPattern, services, searchQueryLanguage, searchString]); | ||
|
|
||
| }), |
There was a problem hiding this comment.
Just wondering if this is necessary, searchQueryLanguage & searchString are both strings, or am I missing something? so why building an object and then converting it to another string?
There was a problem hiding this comment.
Thanks for catching that 🙏 . The dependency previously includes a query object. I removed this now here 02db5e1
qn895
added
auto-backport
9 tasks
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @qn895 |
35 tasks
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
…tistics (elastic#120846) * Add map UI actions to dv * Fix maps logo, comment * Add permission check for ui actions * Remove unnecessary json stringify because it no longer includes query object Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the Maps uiAction to Index data visualizer/Discover's Field statistics:
Screen.Recording.2021-12-08.at.15.40.16.mov
Screen.Recording.2021-12-08.at.15.41.42.mov