Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[context view] Use _doc for tie-breaking instead of _uid #12096

Merged
merged 4 commits into from
Jun 8, 2017
Merged

[context view] Use _doc for tie-breaking instead of _uid #12096

merged 4 commits into from
Jun 8, 2017

Commits on Jun 7, 2017

  1. Make tie-breaking field configurable 

    Using fields with docvalues (like `_doc`) for tie-breaking yields
significantly better performance than using `_uid`, which lacks
docvalues at the moment. The downside is that sorting by `_doc` by
default is not stable under all conditions, but better than no
tie-breaking at all.

The new setting `context:tieBreakingFields` enables the user to
customize the list of fields Kibana attempts to use for tie-breaking.
The first field from that list, that is sortable in the current index
pattern, will be used. It defaults to `_doc`, which should change to
`_seq_no` from version 6.0 on.
    @weltenwort
    weltenwort committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    aeb95b8 View commit details
    Browse the repository at this point in the history

  2. Store failures in state, handle missing tieBreaker 

    In addition to just showing a notification, errors that occur while
loading documents from the database will be stored as part of the
`loadingStatus` along with a reason code (if known). This is used to
display more nuanced and helpful error messages to the user.

The first such error message indicates a missing or invalid tiebreaker
field required for sorting the context.
    @weltenwort
    weltenwort committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    a92628e View commit details
    Browse the repository at this point in the history

  3. Add documentation for new tiebreaker setting

    @weltenwort
    weltenwort committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    e943b89 View commit details
    Browse the repository at this point in the history

  4. Improve wording of the tiebreaker setting description

    @weltenwort
    weltenwort committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    b4890ac View commit details
    Browse the repository at this point in the history