[8.0] chore: Refactors alerts search bar (#119104) #121194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactors alerts search bar * Fixes bad merge
claudiopro
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the alerts search bar to use the nullish coalescing operator
??, extract i18n strings to the newly created translations module, and defining a query language type to avoid repetition.The UI renders fine as before, tests still pass.
Note: this is a manual backport of #119104 to 8.0 as the auto backport failed for merge conflicts.
Related: #121165
Checklist