Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short url browser client #121886

Merged
merged 42 commits into from
Feb 2, 2022
Merged

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Dec 22, 2021

Summary

  • Adds short URL client to the browser.
  • In sharing context menu starts using the short URL client.

Closes #103858
Closes #121888

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers


Release notes

Short URL client is now accessible on the frontend through plugin contract. Dashboard and Discover shared short URLs now contain a short 3-word human-readable slug.

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana vadimkibana marked this pull request as ready for review January 28, 2022 09:32
@vadimkibana vadimkibana requested a review from a team as a code owner January 28, 2022 09:32
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, overall LGTM. Great work @vadimkibana . Left a couple of minor comments.

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@vadimkibana vadimkibana requested a review from a team as a code owner January 31, 2022 11:11
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested remotely, with chrome generating a short browser url for Discover, worked as expected, also goto worked. I like the shy-wooden-tent I've generated, where can I buy it? BTW this this should be added to the description of the PR, how the links now look like
Bildschirmfoto 2022-02-01 um 12 22 00
FYI @dmitriynj just to be aware of this change

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
share 79 80 +1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
share 10 12 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 53.4KB 55.1KB +1.7KB
Unknown metric groups

API count

id before after diff
share 138 139 +1

ESLint disabled line counts

id before after diff
share 7 8 +1

References to deprecated APIs

id before after diff
infra 13 11 -2
ingestPipelines 2 0 -2
ml 65 11 -54
transform 142 140 -2
upgradeAssistant 12 8 -4
total -64

Total ESLint disabled count

id before after diff
share 9 10 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana merged commit 28ba010 into elastic:main Feb 2, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard share menu redundant title Short URL service in browser
6 participants