Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11851 a11y discover field chooser headers (rebased version) #12211

Merged
merged 4 commits into from
Jun 6, 2017
Merged

11851 a11y discover field chooser headers (rebased version) #12211

merged 4 commits into from
Jun 6, 2017

Conversation

aphelionz
Copy link
Contributor

@aphelionz aphelionz commented Jun 6, 2017

Supersedes #12042

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change and then I think we're good to go!

@@ -10,6 +10,9 @@
}

.kuiLocalBreadcrumb {
font-size: 14px;
margin: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add font-weight: normal here to account for the <h1> default styling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@spalger spalger merged commit abe3fb1 into elastic:master Jun 6, 2017
spalger pushed a commit that referenced this pull request Jun 6, 2017
* Discovery heading refactor and a11y tabbing

* CSS Changes based on @cjcenizal's feedback

* Updating docs examples

* adding font-weight: normal

(cherry picked from commit abe3fb1)
@spalger
Copy link
Contributor

spalger commented Jun 6, 2017

5.5/5.x: 9972ad5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants