Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elastic/fleet-server access to agent policies #122320

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Jan 5, 2022

Summary

The GET /api/fleet/agent_policies API was still using the regular Saved Objects client which is preventing the elastic/fleet-server service account from retrieving agent policies. This switches to use the internal SO client which does not require the service account to have explicit SO privileges.

@joshdover joshdover added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.17.0 labels Jan 5, 2022
@joshdover joshdover requested a review from a team as a code owner January 5, 2022 10:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover enabled auto-merge (squash) January 5, 2022 12:18
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
8.0
7.17 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 122320

joshdover added a commit to joshdover/kibana that referenced this pull request Jan 5, 2022
# Conflicts:
#	x-pack/plugins/fleet/server/routes/agent_policy/handlers.ts
kibanamachine added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
joshdover added a commit that referenced this pull request Jan 5, 2022
…122337)

* Fix elastic/fleet-server access to agent policies (#122320)

# Conflicts:
#	x-pack/plugins/fleet/server/routes/agent_policy/handlers.ts

* Fix type import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants