-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix elastic/fleet-server access to agent policies #122320
Merged
joshdover
merged 1 commit into
elastic:main
from
joshdover:fix-fleet-setup-agent-policies
Jan 5, 2022
Merged
Fix elastic/fleet-server access to agent policies #122320
joshdover
merged 1 commit into
elastic:main
from
joshdover:fix-fleet-setup-agent-policies
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
auto-backport
Deprecated - use backport:version if exact versions are needed
v8.1.0
v7.17.0
labels
Jan 5, 2022
Pinging @elastic/fleet (Team:Fleet) |
6 tasks
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
nchaulet
approved these changes
Jan 5, 2022
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Jan 5, 2022
# Conflicts: # x-pack/plugins/fleet/server/routes/agent_policy/handlers.ts
kibanamachine
added a commit
that referenced
this pull request
Jan 5, 2022
joshdover
added a commit
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.17.0
v8.0.0
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
GET /api/fleet/agent_policies
API was still using the regular Saved Objects client which is preventing theelastic/fleet-server
service account from retrieving agent policies. This switches to use the internal SO client which does not require the service account to have explicit SO privileges.