Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Update Field statistics toggle in Discover & Advanced settings description to include docs #122344

Merged
merged 6 commits into from
Jan 12, 2022
Merged

[Discover] Update Field statistics toggle in Discover & Advanced settings description to include docs #122344

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55e111d
Update beta badge & docs
qn895 Dec 21, 2021
c0ec106
Add docs link to Discover, update to current
qn895 Jan 5, 2022
a06ad4e
Revert change to docLinks service
qn895 Jan 6, 2022
8360eb8
Merge remote-tracking branch 'upstream/main' into ml-discover-beta-docs
qn895 Jan 6, 2022
d43f168
Merge branch 'main' into ml-discover-beta-docs
kibanamachine Jan 10, 2022
6b4320b
Merge branch 'main' into ml-discover-beta-docs
kibanamachine Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/plugins/discover/public/components/view_mode_toggle/view_mode_toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export const DocumentViewModeToggle = ({
defaultMessage: 'Beta',
})}
size="s"
iconType="beaker"
className="fieldStatsBetaBadge"
/>
</div>
Expand Down
11 changes: 10 additions & 1 deletion src/plugins/discover/server/ui_settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,16 @@ export const getUiSettings: () => Record<string, UiSettingsParams> = () => ({
description: i18n.translate(
'discover.advancedSettings.discover.showFieldStatisticsDescription',
{
defaultMessage: `Enable "Field statistics" table in Discover.`,
defaultMessage: `Enable {fieldStatisticsDocs} in Discover to explore the fields in your data. This functionality is in beta and is subject to change. `,
values: {
fieldStatisticsDocs:
`<a href="https://www.elastic.co/guide/en/kibana/master/show-field-statistics.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a doc links service that can be used for Discover settings? Hardcoded URLs, with the version hardcoded like master aren't normally used are they?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the docs page not been created yet? I just get a 404.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not merged yet, but we have to create this PR to get the screenshot for the Docs PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI The URL will still be broken until (1) the docs are backported to 7.17, which is "current" now, or (2) 8.0 GAs and becomes "current". I think that's okay for now, but if not you'd have to put a specific version in these URLs.

target="_blank" rel="noopener">` +
i18n.translate('discover.advancedSettings.discover.fieldStatisticsLinkText', {
defaultMessage: 'Field statistics view',
}) +
'</a>',
},
}
),
value: false,
Expand Down