[ResponseOps][Cases] Get reporters and tags by aggregation #123362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
technical debt
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
added
the
release_note:skip
| @@ -74,17 +74,17 @@ export default ({ getService }: FtrProviderContext): void => { | |||
| for (const scenario of [ | |||
| { | |||
| user: globalRead, | |||
| expectedTags: ['sec', 'obs'], | |||
| expectedTags: ['obs', 'sec'], | |||
There was a problem hiding this comment.
Let's try adding a sort to the aggregation to see if we can get the sorting consistent:
"order": { "_key": "asc" }
There was a problem hiding this comment.
I added the _key. I am gonna leave the change of order of values in the tests as obs preceding sec alphabetically.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @cnasikas |
jonathan-buttner
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #98126
Checklist
Delete any items that are not applicable to this PR.
For maintainers