Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Fix typo #123496

Merged
merged 3 commits into from
Jan 21, 2022
Merged

[Maps] Fix typo #123496

merged 3 commits into from
Jan 21, 2022

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Jan 20, 2022
@thomasneirynck thomasneirynck requested a review from a team as a code owner January 20, 2022 18:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor Author

Discovered in #123336

jamster10
jamster10 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@jamster10 jamster10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃, thanks for sorting this. Smaller MR ever 😅

@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

nreese
nreese approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review

@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB -4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 5f8e186 into elastic:main Jan 21, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@jamster10 jamster10 jamster10 approved these changes

@nickpeihl nickpeihl Awaiting requested review from nickpeihl

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thomasneirynck @elasticmachine @kibana-ci @nreese @jamster10 @kibanamachine