[ML] Transforms: Adds reset action to transforms management. #123735

walterra · 2022-01-25T16:09:20Z

Summary

Fixes #118405.

Adds reset action to transforms management. Supports bulk resetting multiple transforms.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2022-01-26T13:40:13Z

Pinging @elastic/ml-ui (:ml)

qn895 · 2022-01-26T18:01:12Z

x-pack/plugins/transform/public/app/hooks/use_reset_transform.tsx

+ if (results.hasOwnProperty(transformId)) {
+ const status = results[transformId];
+
+ // if we are only deleting one transform, show the success toast messages


super duper nit: think the deleting in the comment here and below meant to be resetting

Fixed in 044b4da.

qn895 · 2022-01-26T18:34:20Z

x-pack/plugins/transform/common/api_schemas/type_guards.ts

+): arg is ResetTransformsResponseSchema => {
+ return (
+ isPopulatedObject(arg) &&
+ Object.values(arg).every((d) => isPopulatedObject(d, ['transformReset']))


Will there ever be a case a response has a mix of transformReset and something else? Can we use .some here? Just curious not a suggestion.

The current APIs we have don't allow these combinations at the moment. Depending on the endpoint, this attribute is hard coded for example like transformDeleted or transformReset.

qn895 · 2022-01-26T18:37:33Z

Tested (normal and managed transforms) and functionally LGTM 🎉 . Just had a nit comment.

peteharverson · 2022-01-27T14:25:15Z

...sform/public/app/sections/transform_management/components/action_reset/reset_action_name.tsx

+ const bulkResetButtonDisabledText = i18n.translate(
+ 'xpack.transform.transformList.resetBulkActionDisabledToolTipContent',
+ {
+ defaultMessage: 'One or more selected transforms must be stopped in order to be reseted.',


Typo reseted. Maybe One or more selected transforms must be stopped in order to be reset ?

Maybe we can make it a bit shorter and it might also sound better.

Suggested change

defaultMessage: 'One or more selected transforms must be stopped in order to be reseted.',

defaultMessage: 'One or more selected transforms must be stopped to be reset.',

x-pack/plugins/transform/server/routes/api/transforms.ts

peteharverson · 2022-01-27T14:45:51Z

...sform/public/app/sections/transform_management/components/action_reset/reset_action_name.tsx

+ disabled,
+ isBulkAction,
+}) => {
+ const bulkResetButtonDisabledText = i18n.translate(


For a running transform, these bulk action items aren't being disabled correctly. Here, I think only the Stop action should actually be enabled:

Good catch, I will look into this in a follow up since it's not only affecting the new reset functionality.

szabosteve · 2022-01-27T14:58:18Z

...sform/public/app/sections/transform_management/components/action_reset/reset_action_name.tsx

+ const bulkResetButtonDisabledText = i18n.translate(
+ 'xpack.transform.transformList.resetBulkActionDisabledToolTipContent',
+ {
+ defaultMessage: 'One or more selected transforms must be stopped in order to be reseted.',


Suggested change

defaultMessage: 'One or more selected transforms must be stopped in order to be reseted.',

defaultMessage: 'Stop one or more selected transforms to reset them.',

Fixed as part of ab14042.

walterra · 2022-02-01T08:21:42Z

@elasticmachine merge upstream

kibanamachine · 2022-02-01T08:21:54Z

expected head sha didn’t match current head ref.

kibana-ci · 2022-02-01T10:40:16Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Default CI Group #10 / Uptime app with generated data certificates with certs page "before each" hook for "displays specific certificates"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`transform`	293	298	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`transform`	365.8KB	371.2KB	+5.4KB

History

💚 Build #19998 succeeded 044b4da
💚 Build #19724 succeeded de12f96
💔 Build #19667 failed ee15a85
💔 Build #19442 failed 07d9e7a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

peteharverson

Latest code changes LGTM

[ML] Adds reset action to transforms management.

07d9e7a

walterra added release_note:enhancement :ml Feature:Transforms ML transforms v8.1.0 labels Jan 25, 2022

walterra self-assigned this Jan 25, 2022

walterra added 2 commits January 26, 2022 12:34

[ML] Fix capabilities. Fix tests.

ee15a85

[ML] Fix translations.

f608ad7

walterra mentioned this pull request Jan 26, 2022

[ML] Increase Test Coverage 8.1.0 #117501

Closed

13 tasks

walterra added 2 commits January 26, 2022 14:28

[ML] Extend functional tests.

894b117

[ML] Fix action name.

de12f96

walterra marked this pull request as ready for review January 26, 2022 13:40

walterra requested a review from a team as a code owner January 26, 2022 13:40

walterra requested review from qn895 and peteharverson January 26, 2022 13:40

qn895 reviewed Jan 26, 2022

View reviewed changes

qn895 approved these changes Jan 26, 2022

View reviewed changes

walterra added 2 commits January 27, 2022 10:40

Merge branch 'main' into ml-transform-reset

b7cfbe7

[ML] Fix comment.

044b4da

peteharverson reviewed Jan 27, 2022

View reviewed changes

x-pack/plugins/transform/server/routes/api/transforms.ts Show resolved Hide resolved

peteharverson reviewed Jan 27, 2022

View reviewed changes

szabosteve reviewed Jan 27, 2022

View reviewed changes

walterra added 2 commits January 31, 2022 16:25

[ML] Adds reset transform API tests.

ab14042

Merge branch 'main' into ml-transform-reset

2b4cd35

Merge branch 'main' into ml-transform-reset

53a349b

Merge branch 'main' into ml-transform-reset

591e8ef

peteharverson approved these changes Feb 1, 2022

View reviewed changes

walterra merged commit fd82fea into elastic:main Feb 1, 2022

kibanamachine added the backport:skip This commit does not require backporting label Feb 1, 2022

walterra deleted the ml-transform-reset branch February 1, 2022 11:44

peteharverson added release_note:feature Makes this part of the condensed release notes and removed release_note:enhancement labels Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Transforms: Adds reset action to transforms management. #123735

[ML] Transforms: Adds reset action to transforms management. #123735

walterra commented Jan 25, 2022 •

edited

Loading

elasticmachine commented Jan 26, 2022

qn895 Jan 26, 2022

walterra Jan 27, 2022

qn895 Jan 26, 2022

walterra Jan 27, 2022

qn895 commented Jan 26, 2022 •

edited

Loading

peteharverson Jan 27, 2022

szabosteve Jan 27, 2022

peteharverson Jan 27, 2022

walterra Jan 31, 2022

szabosteve Jan 27, 2022

walterra Jan 31, 2022 •

edited

Loading

walterra commented Feb 1, 2022

kibanamachine commented Feb 1, 2022

kibana-ci commented Feb 1, 2022

peteharverson left a comment

	defaultMessage: 'One or more selected transforms must be stopped in order to be reseted.',
	defaultMessage: 'One or more selected transforms must be stopped to be reset.',

	defaultMessage: 'One or more selected transforms must be stopped in order to be reseted.',
	defaultMessage: 'Stop one or more selected transforms to reset them.',

[ML] Transforms: Adds reset action to transforms management. #123735

[ML] Transforms: Adds reset action to transforms management. #123735

Conversation

walterra commented Jan 25, 2022 • edited Loading

Summary

Checklist

elasticmachine commented Jan 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qn895 commented Jan 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

walterra Jan 31, 2022 • edited Loading

Choose a reason for hiding this comment

walterra commented Feb 1, 2022

kibanamachine commented Feb 1, 2022

kibana-ci commented Feb 1, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Module Count

Async chunks

History

peteharverson left a comment

Choose a reason for hiding this comment

walterra commented Jan 25, 2022 •

edited

Loading

qn895 commented Jan 26, 2022 •

edited

Loading

walterra Jan 31, 2022 •

edited

Loading