[Security Solution][Endpoint] Search responses without a specific namespace to show pending actions #123741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokaditya
changed the title
ashokaditya
added
bug
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
ashokaditya
force-pushed
the
fix/olm-pending_actions_index_name_update-123707
branch
from
ca1235c to
964f6e6
Compare
ashokaditya
force-pushed
the
fix/olm-pending_actions_index_name_update-123707
branch
from
964f6e6 to
eb6b4e4
Compare
kevinlog
reviewed
Jan 25, 2022
x-pack/plugins/security_solution/server/endpoint/utils/audit_log_helpers.ts
Outdated
Show resolved
Hide resolved
ashokaditya
force-pushed
the
fix/olm-pending_actions_index_name_update-123707
branch
from
0457753 to
f006eb1
Compare
|
I checked this out and every looks like it's working! I created 2 policies with different Policy 1 with You can see the entries coming in correctly on the activity log Policy 2 with You can see the entries coming in correctly on the activity log This same Endpoint has used different namespaces and Host Isolation and its Activity log history are preserved as expected. Here are the multiple indices with the different namespaces: |
kevinlog
approved these changes
Jan 25, 2022
paul-tavares
approved these changes
Jan 25, 2022
| export const logsEndpointResponsesRegex = new RegExp( | ||
| `(^\.ds-\.logs-endpoint\.action\.responses-default-).+` | ||
| `(^\.ds-\.logs-endpoint\.action\.responses-\\w+-).+` |
There was a problem hiding this comment.
Do you really need \\w+ here?
There was a problem hiding this comment.
Not really! Just matching the name is enough. Will clean it up in a follow up PR
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 25, 2022
…espace to show pending actions (elastic#123741) * search responses without a specific namespace to show pending actions fixes elastic/issues/123707 * search over all endpoint response indices irrespective of namespace suffix fixes elastic/issues/123707 * match namespace suffixes for endpoint action and response indices fixes elastic/issues/123707 (cherry picked from commit dfd8bfb)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 25, 2022
…espace to show pending actions (elastic#123741) * search responses without a specific namespace to show pending actions fixes elastic/issues/123707 * search over all endpoint response indices irrespective of namespace suffix fixes elastic/issues/123707 * match namespace suffixes for endpoint action and response indices fixes elastic/issues/123707 (cherry picked from commit dfd8bfb)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 26, 2022
…espace to show pending actions (#123741) (#123769) * search responses without a specific namespace to show pending actions fixes /issues/123707 * search over all endpoint response indices irrespective of namespace suffix fixes /issues/123707 * match namespace suffixes for endpoint action and response indices fixes /issues/123707 (cherry picked from commit dfd8bfb) Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jan 26, 2022
…espace to show pending actions (#123741) (#123770) * search responses without a specific namespace to show pending actions fixes /issues/123707 * search over all endpoint response indices irrespective of namespace suffix fixes /issues/123707 * match namespace suffixes for endpoint action and response indices fixes /issues/123707 (cherry picked from commit dfd8bfb) Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>
ashokaditya
deleted the
fix/olm-pending_actions_index_name_update-123707
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Searches response docs in the endpoint response index pattern to determine pending action response counts.
Checklist
Delete any items that are not applicable to this PR.