You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds in-product help to Discover. It addresses these goals:
Improve the empty state of Discover to include extra guidance on how to view data.
Add a product tour to Discover, which is one of the most heavily utilized applications. See this issue for details.
Add pop-over docs to Discover to cover key concepts of the UX. See this issue for details.
Empty state
The updated empty state guides users to take action when Discover shows no results.
2022-01-28_DemoDiscoverEmptyState.mp4
Hack Details/Notes
We currently have to trigger the opening of the Query search and the DatePicker via forcing click events after using the data-test-subj to select the appropriate item - obviously, this is not ideal and is addressed in the linked feature request.
Tour of Document Explorer
A tour introduces the features of the new Document Explorer. The tour includes both text and animated gifs to convey the information.
2022-01-28_DemoDiscoverTour.mp4
Hack Details/Notes
Since certain HTML elements were not able to be targeted via EuiTour natively (such as the Columns button), we had to add two hidden toolbar options to the Discover grid for the sake of floating a beacon near the Columns and Row Height buttons.
The current way of handling EuiTour components means you have to pass around the Tour object to multiple parts of Discover - this is not an ideal solution for something that may only seen once, such as a tour; the linked feature request addresses this concern.
Help on fields
A pop-up describes the field types.
Help on Surrounding documents view
This tooltip was added to answer a common user question of why filters are not active in the Surrounding documents view.
Heenawter
changed the title
[Spacetime] [Discover] Add extra in product help
[Spacetime] [Discover] Add demo of possible in-product help to Discover
Jan 27, 2022
[job][logs] Jest Tests #7 / ContextAppContent test should render discover grid correctly
[job][logs] OSS CI Group #2 / dashboard app using current data dashboard embeddable data grid should expand the detail row when the toggle arrow is clicked
[job][logs] OSS CI Group #2 / dashboard app using current data dashboard embeddable data grid should expand the detail row when the toggle arrow is clicked
[job][logs] OSS CI Group #6 / discover app discover data grid context tests should open the context view with the selected document as anchor
[job][logs] OSS CI Group #6 / discover app discover data grid context tests should open the context view with the selected document as anchor
[job][logs] Jest Tests #7 / Discover component selected index pattern with time field displays chart toggle
[job][logs] Jest Tests #7 / Discover component selected index pattern without time field displays no chart toggle
[job][logs] Jest Tests #7 / Discover component sidebar should be closed if discover:sidebarClosed is true
[job][logs] Jest Tests #7 / Discover component sidebar should be opened if discover:sidebarClosed is false
[job][logs] Jest Tests #7 / Discover component sidebar should be opened if discover:sidebarClosed was not set
[job][logs] Jest Tests #7 / Discover documents layout render complete
[job][logs] Jest Tests #7 / Discover documents layout render complete when loading but documents were already fetched
[job][logs] Jest Tests #7 / Discover documents layout render loading when loading and no documents
[job][logs] Jest Tests #7 / Discover grid view button when another document is expanded, setExpanded is called with the current document
[job][logs] Jest Tests #7 / Discover grid view button when no document is expanded, setExpanded is called with current document
[job][logs] Jest Tests #7 / Discover grid view button when the current document is expanded, setExpanded is called with undefined
[job][logs] Jest Tests #7 / DiscoverGrid Document selection Allows selection/deselection of multiple documents
[job][logs] Jest Tests #7 / DiscoverGrid Document selection copying selected documents to clipboard
[job][logs] Jest Tests #7 / DiscoverGrid Document selection deselection of all selected documents
[job][logs] Jest Tests #7 / DiscoverGrid Document selection no documents are selected initially
[job][logs] Jest Tests #7 / DiscoverGrid Document selection showing only selected documents and remove filter deselecting each doc manually
[job][logs] Jest Tests #7 / DiscoverGrid Document selection showing only selected documents and undo selection
[job][logs] Jest Tests #7 / DiscoverGrid Document selection showing selected documents, underlying data changes, all documents are displayed, selection is gone
[job][logs] Jest Tests #7 / getStateDefaults index pattern with timefield
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to https://github.com/elastic/kibana-team/issues/432
Relies on #122087
Summary
This PR adds in-product help to Discover. It addresses these goals:
Empty state
The updated empty state guides users to take action when Discover shows no results.
2022-01-28_DemoDiscoverEmptyState.mp4
Hack Details/Notes
Query
search and theDatePicker
via forcingclick
events after using thedata-test-subj
to select the appropriate item - obviously, this is not ideal and is addressed in the linked feature request.Tour of Document Explorer
A tour introduces the features of the new Document Explorer. The tour includes both text and animated gifs to convey the information.
2022-01-28_DemoDiscoverTour.mp4
Hack Details/Notes
EuiTour
natively (such as theColumns
button), we had to add two hidden toolbar options to the Discover grid for the sake of floating a beacon near theColumns
andRow Height
buttons.EuiTour
components means you have to pass around theTour
object to multiple parts of Discover - this is not an ideal solution for something that may only seen once, such as a tour; the linked feature request addresses this concern.Help on fields
A pop-up describes the field types.
Help on Surrounding documents view
This tooltip was added to answer a common user question of why filters are not active in the Surrounding documents view.
Related Feature Requests