Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data view management] Make data views sharable #123991

Merged
merged 29 commits into from
Feb 24, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jan 28, 2022

Summary

This PR implements sharing data views across spaces. This involves changing the saved object definition so its sharable - a simple configuration change that has a few small downstream affects, and providing a ui in data view management to set the available spaces for a given data view.

The update data view list, showing space assignment. Clicking on spaces opens the editor -
Screen Shot 2022-01-28 at 11 16 35 AM

Editing the space assignment
Screen Shot 2022-01-28 at 11 19 14 AM

Release notes

Data views can now be shared across spaces via data view management.

@mattkime mattkime requested review from a team as code owners January 28, 2022 05:54
@mattkime mattkime marked this pull request as draft January 28, 2022 05:54
@mattkime mattkime removed the request for review from a team January 28, 2022 16:52
@mattkime mattkime changed the title [data view management] Support for spaces and space management [data view management] Make data views sharable Jan 28, 2022
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServicesSv v8.1.0 labels Jan 28, 2022
@mattkime mattkime added the release_note:feature Makes this part of the condensed release notes label Jan 31, 2022
@mattkime mattkime marked this pull request as ready for review January 31, 2022 02:32
@mattkime mattkime requested review from a team as code owners January 31, 2022 02:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime mattkime added v8.2.0 and removed v8.1.0 labels Feb 1, 2022
@mattkime
Copy link
Contributor Author

mattkime commented Feb 1, 2022

getting input from @mdefazio

@mattkime
Copy link
Contributor Author

mattkime commented Feb 6, 2022

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

mattkime commented Feb 8, 2022

@elasticmachine merge upstream

@mattkime mattkime requested a review from a team as a code owner February 14, 2022 22:26
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file changes in /infra seem accidental, I'll approve but feel free to revert those :)

@mattkime
Copy link
Contributor Author

I've updated the delete modal with the correct text. Further UX refinements will come in additional PRs.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataViewManagement 134 135 +1
savedObjectsManagement 74 76 +2
total +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2790 2795 +5
dataViews 609 616 +7
total +12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewManagement 119.9KB 121.5KB +1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 40.0KB 40.2KB +227.0B
savedObjectsManagement 15.4KB 16.3KB +851.0B
total +1.1KB
Unknown metric groups

API count

id before after diff
data 3387 3392 +5
dataViews 758 765 +7
total +12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit d892498 into elastic:main Feb 24, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 28, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 123991 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 123991 or prevent reminders by adding the backport:skip label.

@mattkime mattkime added the backport:skip This commit does not require backporting label Mar 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 1, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:feature Makes this part of the condensed release notes v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.