[Security Solution] Remove a data fetching hook from the add to timeline action component

x-pack/plugins/security_solution/public/common/lib/kibana/services.ts

@@ -8,7 +8,8 @@
 import { CoreStart } from '../../../../../../../src/core/public';
 import { StartPlugins } from '../../../types';
 
-type GlobalServices = Pick<CoreStart, 'http' | 'uiSettings'> & Pick<StartPlugins, 'data'>;
+type GlobalServices = Pick<CoreStart, 'http' | 'uiSettings' | 'notifications'> &
+ Pick<StartPlugins, 'data'>;
 
 export class KibanaServices {
  private static kibanaVersion?: string;
@@ -19,8 +20,9 @@ export class KibanaServices {
  data,
  kibanaVersion,
  uiSettings,
+ notifications,
  }: GlobalServices & { kibanaVersion: string }) {
- this.services = { data, http, uiSettings };
+ this.services = { data, http, uiSettings, notifications };
  this.kibanaVersion = kibanaVersion;
  }
 

x-pack/plugins/security_solution/public/detections/components/alerts_table/actions.test.tsx

@@ -29,18 +29,28 @@ import type { ISearchStart } from '../../../../../../../src/plugins/data/public'
 import { dataPluginMock } from '../../../../../../../src/plugins/data/public/mocks';
 import { getTimelineTemplate } from '../../../timelines/containers/api';
 import { defaultHeaders } from '../../../timelines/components/timeline/body/column_headers/default_headers';
+import { KibanaServices } from '../../../common/lib/kibana';
+import {
+ DEFAULT_FROM_MOMENT,
+ DEFAULT_TO_MOMENT,
+} from '../../../common/utils/default_date_settings';
 
 jest.mock('../../../timelines/containers/api', () => ({
  getTimelineTemplate: jest.fn(),
 }));
 
+jest.mock('../../../common/lib/kibana');
+
 describe('alert actions', () => {
  const anchor = '2020-03-01T17:59:46.349Z';
  const unix = moment(anchor).valueOf();
  let createTimeline: CreateTimeline;
  let updateTimelineIsLoading: UpdateTimelineLoading;
  let searchStrategyClient: jest.Mocked<ISearchStart>;
  let clock: sinon.SinonFakeTimers;
+ let mockKibanaServices: jest.Mock;
+ let fetchMock: jest.Mock;
+ let toastMock: jest.Mock;
 
  beforeEach(() => {
  // jest carries state between mocked implementations when using
@@ -52,6 +62,14 @@ describe('alert actions', () => {
 
  createTimeline = jest.fn() as jest.Mocked<CreateTimeline>;
  updateTimelineIsLoading = jest.fn() as jest.Mocked<UpdateTimelineLoading>;
+ mockKibanaServices = KibanaServices.get as jest.Mock;
+
+ fetchMock = jest.fn();
+ toastMock = jest.fn();
+ mockKibanaServices.mockReturnValue({
+ http: { fetch: fetchMock },
+ notifications: { toasts: { addError: toastMock } },
+ });
 
  searchStrategyClient = {
  ...dataPluginMock.createStartContract().search,
@@ -418,6 +436,59 @@ describe('alert actions', () => {
  });
 
  describe('determineToAndFrom', () => {
+ const ecsDataMockWithNoTemplateTimeline = getThresholdDetectionAlertAADMock({
+ ...mockAADEcsDataWithAlert,
+ kibana: {
+ alert: {
+ ...mockAADEcsDataWithAlert.kibana?.alert,
+ rule: {
+ ...mockAADEcsDataWithAlert.kibana?.alert?.rule,
+ parameters: {
+ ...mockAADEcsDataWithAlert.kibana?.alert?.rule?.parameters,
+ threshold: {
+ field: ['destination.ip'],
+ value: 1,
+ },
+ },
+ name: ['mock threshold rule'],
+ saved_id: [],
+ type: ['threshold'],
+ uuid: ['c5ba41ab-aaf3-4f43-971b-bdf9434ce0ea'],
+ timeline_id: undefined,
+ timeline_title: undefined,
+ },
+ threshold_result: {
+ count: 99,
+ from: '2021-01-10T21:11:45.839Z',
+ cardinality: [
+ {
+ field: 'source.ip',
+ value: 1,
+ },
+ ],
+ terms: [
+ {
+ field: 'destination.ip',
+ value: 1,
+ },
+ ],
+ },
+ },
+ },
+ });
+ beforeEach(() => {
+ fetchMock.mockResolvedValue({
+ hits: {
+ hits: [
+ {
+ _id: ecsDataMockWithNoTemplateTimeline[0]._id,
+ _index: 'mock',
+ _source: ecsDataMockWithNoTemplateTimeline[0],
+ },
+ ],
+ },
+ });
+ });
  test('it uses ecs.Data.timestamp if one is provided', () => {
  const ecsDataMock: Ecs = {
  ...mockEcsDataWithAlert,
@@ -438,47 +509,6 @@ describe('alert actions', () => {
  });
 
  test('it uses original_time and threshold_result.from for threshold alerts', async () => {
- const ecsDataMockWithNoTemplateTimeline = getThresholdDetectionAlertAADMock({
- ...mockAADEcsDataWithAlert,
- kibana: {
- alert: {
- ...mockAADEcsDataWithAlert.kibana?.alert,
- rule: {
- ...mockAADEcsDataWithAlert.kibana?.alert?.rule,
- parameters: {
- ...mockAADEcsDataWithAlert.kibana?.alert?.rule?.parameters,
- threshold: {
- field: ['destination.ip'],
- value: 1,
- },
- },
- name: ['mock threshold rule'],
- saved_id: [],
- type: ['threshold'],
- uuid: ['c5ba41ab-aaf3-4f43-971b-bdf9434ce0ea'],
- timeline_id: undefined,
- timeline_title: undefined,
- },
- threshold_result: {
- count: 99,
- from: '2021-01-10T21:11:45.839Z',
- cardinality: [
- {
- field: 'source.ip',
- value: 1,
- },
- ],
- terms: [
- {
- field: 'destination.ip',
- value: 1,
- },
- ],
- },
- },
- },
- });
-
  const expectedFrom = '2021-01-10T21:11:45.839Z';
  const expectedTo = '2021-01-10T21:12:45.839Z';
 
@@ -525,4 +555,86 @@ describe('alert actions', () => {
  });
  });
  });
+
+ describe('show toasts when data is malformed', () => {
+ const ecsDataMockWithNoTemplateTimeline = getThresholdDetectionAlertAADMock({
+ ...mockAADEcsDataWithAlert,
+ kibana: {
+ alert: {
+ ...mockAADEcsDataWithAlert.kibana?.alert,
+ rule: {
+ ...mockAADEcsDataWithAlert.kibana?.alert?.rule,
+ parameters: {
+ ...mockAADEcsDataWithAlert.kibana?.alert?.rule?.parameters,
+ threshold: {
+ field: ['destination.ip'],
+ value: 1,
+ },
+ },
+ name: ['mock threshold rule'],
+ saved_id: [],
+ type: ['threshold'],
+ uuid: ['c5ba41ab-aaf3-4f43-971b-bdf9434ce0ea'],
+ timeline_id: undefined,
+ timeline_title: undefined,
+ },
+ threshold_result: {
+ count: 99,
+ from: '2021-01-10T21:11:45.839Z',
+ cardinality: [
+ {
+ field: 'source.ip',
+ value: 1,
+ },
+ ],
+ terms: [
+ {
+ field: 'destination.ip',
+ value: 1,
+ },
+ ],
+ },
+ },
+ },
+ });
+ beforeEach(() => {
+ fetchMock.mockResolvedValue({
+ hits: 'not correctly formed doc',
+ });
+ });
+ test('renders a toast and calls create timeline with basic defaults', async () => {
+ const expectedFrom = DEFAULT_FROM_MOMENT.toISOString();
+ const expectedTo = DEFAULT_TO_MOMENT.toISOString();
+ const timelineProps = {
+ ...defaultTimelineProps,
+ timeline: {
+ ...defaultTimelineProps.timeline,
+ dataProviders: [],
+ dateRange: {
+ start: expectedFrom,
+ end: expectedTo,
+ },
+ description: '',
+ kqlQuery: {
+ filterQuery: null,
+ },
+ resolveTimelineConfig: undefined,
+ },
+ from: expectedFrom,
+ to: expectedTo,
+ };
+
+ delete timelineProps.ruleNote;
+
+ await sendAlertToTimelineAction({
+ createTimeline,
+ ecsData: ecsDataMockWithNoTemplateTimeline,
+ updateTimelineIsLoading,
+ searchStrategyClient,
+ });
+ expect(createTimeline).toHaveBeenCalledTimes(1);
+ expect(createTimeline).toHaveBeenCalledWith(timelineProps);
+ expect(toastMock).toHaveBeenCalled();
+ });
+ });
 });