Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Assert Lens show chart after navigation from Index data visualizer #124579

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Feb 3, 2022

Summary

This PR adds extra coverage to the current Index data visualizer table by navigating to lens using the action and check if the charts actually show up.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 self-assigned this Feb 3, 2022
@qn895 qn895 added :ml Feature:File and Index Data Viz ML file and index data visualizer labels Feb 3, 2022
@qn895 qn895 marked this pull request as ready for review February 3, 2022 23:36
@qn895 qn895 requested a review from a team as a code owner February 3, 2022 23:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Feb 3, 2022
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 added auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Feb 4, 2022
@qn895 qn895 merged commit f7661c0 into elastic:main Feb 4, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 4, 2022
…er (elastic#124579)

* Assert Lens show chart after navigation from data viz

* Fix tests

(cherry picked from commit f7661c0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 4, 2022
…er (#124579) (#124737)

* Assert Lens show chart after navigation from data viz

* Fix tests

(cherry picked from commit f7661c0)

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
@qn895 qn895 deleted the dv-lens-add-func-tests-content branch July 20, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants