Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] Reverts PR 124310 #124736

Merged
merged 4 commits into from
Feb 5, 2022
Merged

[Security Solutions] Reverts PR 124310 #124736

merged 4 commits into from
Feb 5, 2022

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented Feb 4, 2022 •
edited
Loading

Summary

Reverts #124310 through the commands:

git revert 30f2ce42f0f9a4c4ae902ca2ababbf7d56a8fadf --no-commit
git revert de32a55bcf479bf42122aa78467fedb450d15c78 --no-commit
git checkout -b 'revert-124310'
git add .
git push

Double check that this does look like a revert of that PR. This is for main only.

Instead this will be fixed by:
#124331

Issue for reference:
#124307

@FrankHassanabad FrankHassanabad self-assigned this Feb 4, 2022
@FrankHassanabad FrankHassanabad added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Feb 4, 2022
@FrankHassanabad FrankHassanabad marked this pull request as ready for review February 4, 2022 18:04
@FrankHassanabad FrankHassanabad requested a review from a team as a code owner February 4, 2022 18:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@FrankHassanabad FrankHassanabad enabled auto-merge (squash) February 4, 2022 18:23
@FrankHassanabad FrankHassanabad changed the title Reverts PR 124310 [Security Solutions] Reverts PR 124310 Feb 4, 2022
@FrankHassanabad
Copy link
Contributor Author

@elasticmachine merge upstream

YulNaumenko
YulNaumenko approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@FrankHassanabad
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB -94.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad FrankHassanabad merged commit ea6347c into elastic:main Feb 5, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 5, 2022
@FrankHassanabad FrankHassanabad deleted the revert-124310 branch February 5, 2022 17:24
@kibanamachine kibanamachine mentioned this pull request Feb 8, 2022
Merged
2 tasks
@kqualters-elastic kqualters-elastic mentioned this pull request Feb 8, 2022
Merged
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 8, 2022
@FrankHassanabad @kqualters-elastic
Reverts PR 124310 (elastic#124736)
e3f3b58 
## Summary

Reverts elastic#124310 through the commands:

```sh
git revert 30f2ce4 --no-commit
git revert de32a55 --no-commit
git checkout -b 'revert-124310'
git add .
git push
```

Double check that this does look like a revert of that PR. This is for `main` only.

(cherry picked from commit ea6347c)
kqualters-elastic added a commit that referenced this pull request Feb 8, 2022
@kqualters-elastic @FrankHassanabad
Reverts PR 124310 (#124736) (#125021)
0681fd1 
## Summary

Reverts #124310 through the commands:

```sh
git revert 30f2ce4 --no-commit
git revert de32a55 --no-commit
git checkout -b 'revert-124310'
git add .
git push
```

Double check that this does look like a revert of that PR. This is for `main` only.

(cherry picked from commit ea6347c)

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FrankHassanabad @elasticmachine @kibana-ci @YulNaumenko @kqualters-elastic @kibanamachine