Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests for the Overview page and side nav #124793

Merged
merged 10 commits into from
Feb 8, 2022

Conversation

darnautov
Copy link
Contributor

Summary

Part of #117501

Adds functional tests for the Overview page and side navigation.

Checklist

@darnautov darnautov added :ml test_ui_functional auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 Team:ML Team label for ML (also use :ml) v8.2.0 labels Feb 7, 2022
@darnautov darnautov requested a review from pheyos February 7, 2022 11:14
@darnautov darnautov self-assigned this Feb 7, 2022
@darnautov darnautov requested a review from a team as a code owner February 7, 2022 11:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov added the release_note:skip Skip the PR/issue when compiling release notes label Feb 7, 2022
@darnautov darnautov mentioned this pull request Feb 7, 2022
13 tasks
@darnautov darnautov requested a review from pheyos February 7, 2022 15:51
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +204.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@darnautov darnautov merged commit a248af0 into elastic:main Feb 8, 2022
@darnautov darnautov deleted the ml-117501-overview-page-tests branch February 8, 2022 09:22
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2022
)

* update side nav tests for full ml access

* ML nodes tests

* assert empty states

* assert getting started callout

* assert panels with data

* assert read ml access

* waitForDatePickerIndicatorLoaded

* add missing step

* fix typo

* rename variable

(cherry picked from commit a248af0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 8, 2022
…124922)

* update side nav tests for full ml access

* ML nodes tests

* assert empty states

* assert getting started callout

* assert panels with data

* assert read ml access

* waitForDatePickerIndicatorLoaded

* add missing step

* fix typo

* rename variable

(cherry picked from commit a248af0)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test_ui_functional v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants