Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data view management] Fix set default data view permissions check #124897

Merged
merged 8 commits into from
Feb 9, 2022
Merged

[data view management] Fix set default data view permissions check #124897

merged 8 commits into from
Feb 9, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Feb 7, 2022 •
edited
Loading

Summary

Adds permission check for 'Set as default data view' and clean up permissions checks in Data View Management

Closes: #106586

Release note

Adds permission check for 'Set as default data view' button on data view detail page.

@mattkime mattkime added v7.17.1 v8.0.1 v8.2.0 v8.1.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:AppServicesSv release_note:fix labels Feb 8, 2022
@mattkime mattkime changed the title fix set default data view permissions [data view management] Fix set default data view permissions check Feb 8, 2022
@mattkime mattkime marked this pull request as ready for review February 8, 2022 04:43
@mattkime mattkime requested a review from a team as a code owner February 8, 2022 04:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

shivindera
shivindera approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@shivindera shivindera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewManagement 120.4KB 119.8KB -666.0B
Unknown metric groups

References to deprecated APIs

id before after diff
dataViewManagement 29 28 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 9, 2022
@mattkime mattkime merged commit ded0478 into elastic:main Feb 9, 2022
@mattkime mattkime mentioned this pull request Feb 9, 2022
Merged
mattkime added a commit to mattkime/kibana that referenced this pull request Feb 9, 2022
@mattkime
[data view management] Fix set default data view permissions check (e…
f5e017a 
…lastic#124897)

* fix set default data view permissions

* fix fields table

* fix scripted field add button

* fix jest tests

* lint fixes

* fix test

* updte snapshot

(cherry picked from commit ded0478)
@elastic elastic deleted a comment from kibanamachine Feb 9, 2022
mattkime added a commit that referenced this pull request Feb 9, 2022
@mattkime
[data view management] Fix set default data view permissions check (#…
110f9fe 
…124897) (#125126)

* fix set default data view permissions

* fix fields table

* fix scripted field add button

* fix jest tests

* lint fixes

* fix test

* updte snapshot

(cherry picked from commit ded0478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivindera shivindera shivindera approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:fix v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimally privileged user cannot set default index pattern
4 participants
@mattkime @elasticmachine @kibana-ci @shivindera