-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Screenshotting] Add custom context support in the screenshot mode #124942
Conversation
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
34ce649
to
e3b8d58
Compare
e3b8d58
to
6936094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code only review: Presentation team changes LGTM!
6936094
to
0c88fb9
Compare
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
Unreferenced deprecated APIs
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @dokmic these changes look good and contain some nice code cleanup!
I tested locally using the reporting integration example app and was able to see screenshot mode being detected correctly and tested on dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Very cool change :)
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Resolves #122773.
Checklist
For maintainers