Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screenshotting] Add custom context support in the screenshot mode #124942

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Feb 8, 2022

Summary

Resolves #122773.

Checklist

For maintainers

@dokmic dokmic added review (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx v8.2.0 labels Feb 8, 2022
@dokmic dokmic requested review from a team as code owners February 8, 2022 12:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@dokmic dokmic requested a review from a team as a code owner February 8, 2022 15:52
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review: Presentation team changes LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
screenshotMode 7 8 +1
screenshotting 8 - -8
total -7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
screenshotMode 24 14 -10
screenshotting 11 8 -3
total -13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 293.1KB 293.1KB +9.0B
reporting 59.2KB 59.2KB -30.0B
total -21.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
screenshotMode 1 0 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
screenshotMode 2.0KB 2.0KB +41.0B
screenshotting 2.0KB - -2.0KB
total -1.9KB
Unknown metric groups

API count

id before after diff
screenshotMode 29 33 +4
screenshotting 25 17 -8
total -4

References to deprecated APIs

id before after diff
dashboard 84 83 -1
screenshotting 12 0 -12
total -13

Unreferenced deprecated APIs

id before after diff
screenshotMode 3 0 -3

History

  • 💚 Build #22545 succeeded 6936094e6ec39e2087aca7c35e7aedeb2e7eca10
  • 💔 Build #22518 failed e3b8d5824671cb496755212769476401d25915c1
  • 💔 Build #22435 failed 34ce64960f8a8b1e8db24acca8b947dd701ee632

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @dokmic these changes look good and contain some nice code cleanup!

I tested locally using the reporting integration example app and was able to see screenshot mode being detected correctly and tested on dashboard.

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very cool change :)

@dokmic dokmic merged commit 9ac1916 into elastic:main Feb 11, 2022
@dokmic dokmic deleted the feature/122773 branch February 11, 2022 09:14
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124942 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Feb 15, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Screenshotting] Extend the screenshot mode plugin to support custom contextual data
8 participants