Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC][LOGS] Add reason message as a rule variable. #124978

Merged
merged 9 commits into from
Feb 11, 2022

Conversation

fkanout
Copy link
Contributor

@fkanout fkanout commented Feb 8, 2022

Summary

It closes 123916

Screenshot 2022-02-09 at 15 12 02

Checklist

Delete any items that are not applicable to this PR.

@fkanout fkanout self-assigned this Feb 8, 2022
@fkanout fkanout added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.2.0 labels Feb 8, 2022
@fkanout fkanout changed the title [RAC][LOGS] Add reason message as rule variable. [RAC][LOGS] Add reason message as a rule variable. Feb 8, 2022
@fkanout fkanout marked this pull request as ready for review February 9, 2022 14:14
@fkanout fkanout requested a review from a team as a code owner February 9, 2022 14:14
@fkanout fkanout requested a review from a team February 9, 2022 14:14
@fkanout fkanout added the release_note:skip Skip the PR/issue when compiling release notes label Feb 9, 2022
@fkanout
Copy link
Contributor Author

fkanout commented Feb 9, 2022

@elasticmachine merge upstream

@mgiota mgiota self-requested a review February 10, 2022 07:30
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @fkanout I just left a few minor comments regarding updating the tests to the latest reason format.

@fkanout
Copy link
Contributor Author

fkanout commented Feb 10, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @fkanout

@fkanout fkanout merged commit dd0749a into elastic:main Feb 11, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124978 or prevent reminders by adding the backport:skip label.

@mgiota
Copy link
Contributor

mgiota commented Feb 15, 2022

@fkanout I think you need to add backport:skip label in this PR

@spalger spalger added the backport:skip This commit does not require backporting label Feb 15, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
@fkanout
Copy link
Contributor Author

fkanout commented Feb 23, 2022

@mgiota This PR is part of the v8.2 scope only. Backporting it would mean including it in the v8.1. Did I miss something here?

@fkanout
Copy link
Contributor Author

fkanout commented Feb 23, 2022

It seems that it requires explicitly skipping the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAC][LOGS] Add {{context.reason}} variable to the rule templating language
5 participants