-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC][LOGS] Add reason message as a rule variable. #124978
[RAC][LOGS] Add reason message as a rule variable. #124978
Conversation
@elasticmachine merge upstream |
x-pack/plugins/infra/server/lib/alerting/log_threshold/log_threshold_executor.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/server/lib/alerting/log_threshold/log_threshold_executor.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/server/lib/alerting/log_threshold/log_threshold_executor.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @fkanout I just left a few minor comments regarding updating the tests to the latest reason format.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @fkanout |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
@fkanout I think you need to add |
@mgiota This PR is part of the |
It seems that it requires explicitly skipping the backport. |
Summary
It closes 123916
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis renders correctly on smaller devices using a responsive layout. (You can test this in your browser)This was checked for cross-browser compatibility