Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] [Security Solution] Remove a data fetching hook from the add to timeline action component (#124331) #125020

Closed
wants to merge 1 commit into from
Closed

[8.0] [Security Solution] Remove a data fetching hook from the add to timeline action component (#124331) #125020

wants to merge 1 commit into from

Conversation

kqualters-elastic
Copy link
Contributor

Backport

This is an automatic backport to 8.0 of:

Questions ?

Please refer to the Backport tool documentation

@kqualters-elastic
[Security Solution] Remove a data fetching hook from the add to timel…
d20de8c 
…ine action component (elastic#124331)

* Fetch alert ecs data in actions.tsx and not a hook in every table row

* Add error handling and tests for theshold timelines

* Fix bad merge

* Remove unused imports

* Actually remove unused file

* Remove usage of alertIds and dead code from cases

* Add basic sanity tests that ensure no extra network calls are being made

* Remove unused operator

* Remove unused imports

* Remove unused mock

(cherry picked from commit e312c36)
@kqualters-elastic kqualters-elastic enabled auto-merge (squash) February 8, 2022 20:57
@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 8, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / Details Panel Component DetailsPanel:EventDetails: rendering it should render the Event Details view of the Details Panel in the flyout when the panelView is eventDetail and the eventId is set
  • [job] [logs] Jest Tests #1 / event details footer component it renders the take action dropdown

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2811 2810 -1
timelines 288 285 -3
total -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB -341.0B
timelines 237.1KB 235.8KB -1.3KB
total -1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 247.1KB 247.2KB +32.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic kqualters-elastic deleted the backport/8.0/pr-124331 branch February 8, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kqualters-elastic @kibana-ci