Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics saved search creation functional tests #125040

Merged
merged 6 commits into from
Feb 15, 2022
Merged

[ML] Data Frame Analytics saved search creation functional tests #125040

merged 6 commits into from
Feb 15, 2022

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Feb 9, 2022 •
edited
Loading

Summary

Related meta issue: #117501

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner February 9, 2022 04:59
@alvarezmelissa87 alvarezmelissa87 self-assigned this Feb 9, 2022
@alvarezmelissa87 alvarezmelissa87 added :ml Feature:Data Frame Analytics ML data frame analytics features Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Feb 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this pull request Feb 9, 2022
Closed
13 tasks
@walterra walterra mentioned this pull request Feb 9, 2022
Closed
5 tasks
pheyos
pheyos approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one small thing: I forgot to delete x-pack/test/functional/es_archives/ml/data.json.gz.backup in my suggested changes. This file is not needed anymore and could be removed.

@alvarezmelissa87
Copy link
Contributor Author

LGTM Just one small thing: I forgot to delete x-pack/test/functional/es_archives/ml/data.json.gz.backup in my suggested changes. This file is not needed anymore and could be removed.

Removed in c0a3acf

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #1 / Execution context Browser apps dashboard app propagates context for Vertical bar visualization

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit c961b4b into elastic:main Feb 15, 2022
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Feb 15, 2022
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Feb 15, 2022
@alvarezmelissa87
[ML] Data Frame Analytics saved search creation functional tests (ela…
f7d8226 
…stic#125040)

* create filter saved search test for each dfa job type

* add search query test cases

* temp comment of failing with insuff memory test case

* remove problem case and update test text

* Use downsampled farequote archive

* remove unnecessary file

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
(cherry picked from commit c961b4b)
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-tests-addition branch February 15, 2022 20:11
alvarezmelissa87 added a commit that referenced this pull request Feb 15, 2022
@alvarezmelissa87
[ML] Data Frame Analytics saved search creation functional tests (#12…
eae9680 
…5040) (#125719)

* create filter saved search test for each dfa job type

* add search query test cases

* temp comment of failing with insuff memory test case

* remove problem case and update test text

* Use downsampled farequote archive

* remove unnecessary file

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
(cherry picked from commit c961b4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvarezmelissa87 @elasticmachine @kibana-ci @pheyos