Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Frame Analytics audit messages api test #125325

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

Summary

Related meta issue: #117501

  • Creates api tests for DFA job audit messages

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 self-assigned this Feb 10, 2022
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner February 10, 2022 23:08
@alvarezmelissa87 alvarezmelissa87 added :ml Feature:Data Frame Analytics ML data frame analytics features release_note:skip Skip the PR/issue when compiling release notes test_api labels Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

);
});

it('should not allow to retrieve a job stats for the user without required permissions', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a copy and paste from one of the job stats tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - accidentally left in - fixed in 49371743f19221b4c20d62d87e9227545366a280

@alvarezmelissa87
Copy link
Contributor Author

This has been updated and is ready for a final look cc @pheyos, @peteharverson

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #23610 succeeded 49371743f19221b4c20d62d87e9227545366a280
  • 💔 Build #23317 failed 2cd2f89dff4308bf74ed750606620c288f70511b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit eafa4d9 into elastic:main Feb 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 15, 2022
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-api-tests-addition branch February 15, 2022 20:18
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Feb 15, 2022
* wip: add beginning of messages api test

* adds dfa audit messages api test

* use retry instead of running job

(cherry picked from commit eafa4d9)
alvarezmelissa87 added a commit that referenced this pull request Feb 15, 2022
* wip: add beginning of messages api test

* adds dfa audit messages api test

* use retry instead of running job

(cherry picked from commit eafa4d9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes test_api v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants