New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make embeddable example plugin not fail for read-only user #125459

Merged

vadimkibana merged 2 commits into elastic:main from vadimkibana:emb-plugin

Feb 14, 2022

Contributor

vadimkibana commented Feb 13, 2022 •

edited

Loading

Summary

Embeddable sample plugin crashes if it does not have write permissions, because it tries to write sample data to ES. This TryCatchBlock makes sure the plugin does not crash if the write request fails.

For maintainers

This was checked for breaking API changes and was labeled appropriately

vadimkibana added 2 commits

February 13, 2022 19:31


          wrap write operation in try-catch block

f010c04


          add space

e59c457

Collaborator

kibana-ci commented Feb 13, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💔 Build #23739 failed f010c04

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

vadimkibana marked this pull request as ready for review

February 14, 2022 08:26

vadimkibana requested a review from a team as a code owner

February 14, 2022 08:26

vadimkibana added release_note:skip v8.2.0 labels

jloleysens approved these changes

View reviewed changes

vadimkibana merged commit 8f4de1b into elastic:main

kibanamachine added the backport missing label

Contributor

kibanamachine commented Feb 16, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

19 similar comments

Contributor

kibanamachine commented Feb 17, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Feb 18, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Feb 21, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Feb 22, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Feb 23, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Feb 24, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Feb 25, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Feb 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 2, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 3, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 4, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 7, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 8, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 9, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 10, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 11, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 14, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 15, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 16, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

10 similar comments

Contributor

kibanamachine commented Mar 17, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 18, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 21, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 22, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 23, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 24, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 25, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 29, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 30, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125459 or prevent reminders by adding the backport:skip label.

spalger added the backport:skip label

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip release_note:skip v8.2.0