-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] revert package policy validation that caused issue with input groups #125657
[Fleet] revert package policy validation that caused issue with input groups #125657
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
…lastic#125657) (cherry picked from commit 35f4ba5)
…lastic#125657) (cherry picked from commit 35f4ba5)
💔 Some backports could not be created
How to fixRe-run the backport manually:
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…lastic#125657) (cherry picked from commit 35f4ba5) # Conflicts: # x-pack/plugins/fleet/common/services/validate_package_policy.test.ts
…groups (#125657) (#136338) * revert package policy validation that caused issue with input groups (#125657) (cherry picked from commit 35f4ba5) # Conflicts: # x-pack/plugins/fleet/common/services/validate_package_policy.test.ts * Skip test Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Summary
Partially revert #124215 to unblock #125625
Improvement of validation is raised here #125655
To summarize:
Aws package policy generated by elastic-package is rejected with validation errors, however it should be accepted.
The reason is that policy vars present in package definition global vars, are listed under inputs/streams.
This should be accepted according to this: #125625 (comment)
Example package policy that should be valid, see below.
To verify, run this with a valid agent policy id in
policy_id
, and verify that it is successfully created.