Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Support logstash as an output type in API and Kibana config #125990

Merged
merged 10 commits into from
Mar 1, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Feb 17, 2022

Summary

Resolve #125792

Add support for logasth type in Fleet ouput API and preconfiguration.

The logstash output require the host to not contains the schema, and allow to configure SSL options.

That PR add a new ssl key to the output saved object that is not indexed

Test

The API changes are covered by API integration tests

How to test

You can create a logstash output by adding the following in your Kibana config

xpack.fleet.outputs:
  - id: test123
    name: Test logstash
    hosts: [test.fr:443]
    type: "logstash"
    is_default: true
    is_default_monitoring: true
    ssl: 
      certificate_authorities: ['REPLACE_CACERT1']
      certificate: 'REPLACE_CERT'
      key: 'REPLACE_KEY'

You should see the output correctly created in Kibana and used in the agent policy (it's not editable for now the UI will come in a following PR)
Screen Shot 2022-02-21 at 8 56 37 AM

@lykkin This should allow us to start E2E testing with the Agent.

@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 labels Feb 17, 2022
@nchaulet nchaulet self-assigned this Feb 17, 2022
@nchaulet nchaulet force-pushed the feature-logstash-output-api branch 2 times, most recently from 2715805 to ab55cb8 Compare February 17, 2022 21:08
@nchaulet nchaulet marked this pull request as ready for review February 21, 2022 14:06
@nchaulet nchaulet requested a review from a team as a code owner February 21, 2022 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Feb 21, 2022
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested functionality, looks good on UI

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1232 1233 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 110.5KB 110.5KB +20.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
ingest-outputs 12 13 +1
Unknown metric groups

API count

id before after diff
fleet 1349 1350 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit e0e14c4 into elastic:main Mar 1, 2022
@nchaulet nchaulet deleted the feature-logstash-output-api branch March 1, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add logstash output type in output API and preconfiguration
6 participants