Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] added support for dimension field #126257

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

juliaElastic
Copy link
Contributor

Summary

Closes #115620

Added support for dimension field.

In packages field definitions, a dimension is defined as a boolean value in a fields definition, for example:

- name: example.id
  type: keyword
  dimension: true

This should be translated into a mapping including the time_series_dimension parameter (added in elastic/elasticsearch#74014) set to true, something like this:

...
  "mappings": {
    "properties":
      "example":
        "properties":
          "id": {
            "type": "keyword",
            "time_series_dimension": true
          }
       }
    }
...

Checklist

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.2.0 labels Feb 23, 2022
@juliaElastic juliaElastic self-assigned this Feb 23, 2022
@juliaElastic juliaElastic requested a review from a team as a code owner February 23, 2022 15:25
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 1b75f2e into elastic:main Feb 23, 2022
@juliaElastic juliaElastic deleted the add-dimension-field branch February 23, 2022 17:07
@jen-huang jen-huang added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Feb 23, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@juliaElastic
Copy link
Contributor Author

manual test case here: #115620 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for dimension fields defined in packages
6 participants