Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PluginsStatusService: reuse plugin status observables #126334

Merged
merged 1 commit into from
Feb 24, 2022
Merged

PluginsStatusService: reuse plugin status observables #126334

merged 1 commit into from
Feb 24, 2022

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Feb 24, 2022 •
edited
Loading

Summary

Optimize the internals of PluginsStatusService by avoiding to recreate distinct observables everytime getAll$, getDependenciesStatus$ or getDerivedStatus$ is called.

Significantly reduce the number of internal observables too as getDerivedStatus$ is called within getPluginStatuses$

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.2.0 labels Feb 24, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review February 24, 2022 13:40
@pgayvallet pgayvallet requested a review from a team as a code owner February 24, 2022 13:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

TinaHeiligers
TinaHeiligers approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization!
LGTM

@pgayvallet pgayvallet merged commit c914e94 into elastic:main Feb 24, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 28, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126334 or prevent reminders by adding the backport:skip label.

@pgayvallet pgayvallet added the backport:skip This commit does not require backporting label Mar 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 1, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@pgayvallet @lucasfcosta
[Status service] reuse plugin status observables (elastic#126334)
49956ab
@EricDavisX EricDavisX mentioned this pull request Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting performance release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgayvallet @kibana-ci @elasticmachine @kibanamachine @TinaHeiligers